Migrate IfThisTestFailsThenHitTermsAreBroken to AbstractQueryTest#3680
Open
apmoriarty wants to merge 1 commit into
Open
Migrate IfThisTestFailsThenHitTermsAreBroken to AbstractQueryTest#3680apmoriarty wants to merge 1 commit into
apmoriarty wants to merge 1 commit into
Conversation
Drops Arquillian (which had no @deployment method and never actually ran) and Spring in favor of AbstractQueryTest, whose built-in expectHitTermsRequiredAllOf/AnyOf and hit-term validation already replicate this test's original hand-rolled HitTermAssertions usage. ShardRange/DocumentRange split dropped; ingest now writes the document range only and adds an IndexIngestUtil call so AbstractQueryTest's index-table-variant iteration works. All 10 tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lbschanno
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops Arquillian (which had no @deployment method and never actually ran) and Spring in favor of AbstractQueryTest, whose built-in expectHitTermsRequiredAllOf/AnyOf and hit-term validation already replicate this test's original hand-rolled HitTermAssertions usage. ShardRange/DocumentRange split dropped; ingest now writes the document range only and adds an IndexIngestUtil call so AbstractQueryTest's index-table-variant iteration works. All 10 tests pass.