Migrate HitsAreAlwaysIncludedCommonalityTokenTest from Arquillian to AbstractQueryTest#3679
Open
apmoriarty wants to merge 1 commit into
Open
Conversation
…AbstractQueryTest Uses ShardQueryLogic (EventQuery bean), extends AbstractQueryTest directly. The original runTestQuery() used a single mutable goodResults set for two purposes: non-destructively checking hit-term content membership, and destructively consuming it via remove() while walking each returned document's field dictionary, asserting it empty after each document. That logic is preserved verbatim in extraAssertions(), matched against a local copy since planAndExecuteQuery() invokes extraAssertions() once per index table variant. Plan assertion disabled (original never checked the planned query string). Per the established pattern for this batch, the ShardRange/ DocumentRange nested-subclass split is dropped: data is ingested once via CommonalityTokenTestDataIngest with the DOCUMENT range only, since that ingest helper already calls IndexIngestUtil internally to derive the other shard index table variants AbstractQueryTest iterates over. Both tests pass. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
lbschanno
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.