Migrate ExecutableExpansionVisitorTest from Arquillian to AbstractQueryTest#3677
Draft
apmoriarty wants to merge 1 commit into
Draft
Migrate ExecutableExpansionVisitorTest from Arquillian to AbstractQueryTest#3677apmoriarty wants to merge 1 commit into
apmoriarty wants to merge 1 commit into
Conversation
…ryTest Drops the Arquillian container deployment and the ShardRangeExecutableExpansion/ DocumentRange nested subclasses in favor of extending AbstractQueryTest directly. This file mixes two very different kinds of tests: - ~19 integration-style tests that ingest data and call runTestQuery (renamed here to use givenQuery/expectUUIDs/planAndExecuteQuery), which are parameterized over SHARD/DOCUMENT range via @ParameterizedTest, with a couple using @MethodSource where the original looped over multiple query-string/expected-UUID cases. Ingestion for both ranges happens once in @BeforeAll. - ~13 pure unit tests of ExecutableExpansionVisitor/ExecutableDeterminationVisitor against Mockito-mocked ShardQueryConfiguration/MetadataHelper that never touch the ingested data or query logic at all. These are left as plain single @test methods with no range parameter, since the old ShardRange/DocumentRange split needlessly ran them twice for no reason - range was never relevant to them. Query plan assertion is disabled by default; a handful of tests that originally asserted the final planned query tree via manual TreeEqualityVisitor calls keep doing so directly in the test body after planAndExecuteQuery(), since that maps onto exactly what AbstractQueryTest's own plan assertion already does internally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Arquillian container deployment and the ShardRangeExecutableExpansion/ DocumentRange nested subclasses in favor of extending AbstractQueryTest directly. This file mixes two very different kinds of tests:
Query plan assertion is disabled by default; a handful of tests that originally asserted the final planned query tree via manual TreeEqualityVisitor calls keep doing so directly in the test body after planAndExecuteQuery(), since that maps onto exactly what AbstractQueryTest's own plan assertion already does internally.