Migrate KeywordQueryLogicFunctionalTest from Arquillian to JUnit5/Spring#3670
Merged
Merged
Conversation
Drops the Arquillian container deployment in favor of SpringExtension with the same context config used by the AbstractQueryTest-based tests. KeywordQueryLogic does not extend ShardQueryLogic, so this test cannot extend AbstractQueryTest itself, but table setup/ingest and test lifecycle now match the pattern used elsewhere (QueryTestTableHelper + WiseGuysIngest under @BeforeAll, JUnit5 assertions). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
not to harp on it, but while we're at it with these migrations and refactors maybe could check out if its worth switching the log4j library for slf4j? Would be curious to hear what you think about it |
Collaborator
Author
Do you mind if I do that a series of separate PRs? |
Collaborator
that's fine with me, LGTM |
lbschanno
approved these changes
Jul 10, 2026
hoper-38709
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops the Arquillian container deployment in favor of SpringExtension with the same context config used by the AbstractQueryTest-based tests. KeywordQueryLogic does not extend ShardQueryLogic, so this test cannot extend AbstractQueryTest itself, but table setup/ingest and test lifecycle now match the pattern used elsewhere (QueryTestTableHelper + WiseGuysIngest under @BeforeAll, JUnit5 assertions).