Skip to content

[AIDynamo] git repos#961

Merged
podkidyshev merged 1 commit into
mainfrom
ipod/dynamo-git-repos
Jul 7, 2026
Merged

[AIDynamo] git repos#961
podkidyshev merged 1 commit into
mainfrom
ipod/dynamo-git-repos

Conversation

@podkidyshev

Copy link
Copy Markdown
Contributor

Summary

Enable git_repos feature for AIDynamo

Test Plan

  • Automated CI
  • Manual test runs

Additional Notes

@podkidyshev podkidyshev self-assigned this Jul 6, 2026
@podkidyshev podkidyshev added the bug Something isn't working label Jul 6, 2026
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 29253f02-a70e-447f-912c-ebdc9fcaa38f

📥 Commits

Reviewing files that changed from the base of the PR and between f349a8f and 9c2d895.

📒 Files selected for processing (2)
  • src/cloudai/workloads/ai_dynamo/ai_dynamo.py
  • tests/workloads/ai_dynamo/test_command_gen_strategy_slurm.py

📝 Walkthrough

Walkthrough

AIDynamoTestDefinition.installables now includes superclass installables via *super().installables alongside existing items. A new test verifies that custom top-level GitRepo objects passed via git_repos are included in the resulting installables list.

Changes

AIDynamoTestDefinition installables fix

Layer / File(s) Summary
Include superclass installables and verify
src/cloudai/workloads/ai_dynamo/ai_dynamo.py, tests/workloads/ai_dynamo/test_command_gen_strategy_slurm.py
installables property splices in *super().installables; new test confirms a custom GitRepo passed via git_repos appears in tdef.installables.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Related PRs: None found.

Suggested labels: bug, tests

Suggested reviewers: None specified.

🥁 A tiny splice, a quiet fix,
super's gifts now in the mix,
a GitRepo test to seal the deal,
installables now made real,
hop along, the code's more whole. 🐇

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change by pointing to AIDynamo git repo support.
Description check ✅ Passed The description is directly related and correctly states that AIDynamo git_repos support is being enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ipod/dynamo-git-repos

Comment @coderabbitai help to get the list of available commands.

@podkidyshev
podkidyshev marked this pull request as ready for review July 6, 2026 20:12
@podkidyshev
podkidyshev merged commit 5b0d078 into main Jul 7, 2026
8 checks passed
@podkidyshev
podkidyshev deleted the ipod/dynamo-git-repos branch July 7, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants