-
Notifications
You must be signed in to change notification settings - Fork 470
[STF] Add bundles: grouped logical data as a single task dependency #10837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
caugonnet
wants to merge
15
commits into
NVIDIA:main
Choose a base branch
from
caugonnet:stf-compound-logical-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
09c5c3e
[STF] Add bundles: grouped logical data as a single task dependency
caugonnet f69e207
[STF] Bundles: token-aware grouping, launch and partitioner parallel_…
caugonnet 06012e2
[STF] Bundles: guard bundle launch/partitioner overloads, cover cuda_…
caugonnet f534b2f
[STF] Bundles test: drop unused lambda capture (Clang14 -Werror)
caugonnet 8d4e1fe
[STF] Bundles: avoid identifier 'I' in headers (complex.h macro lint)
caugonnet ce5408e
[STF] Python bundles: same semantics as the C++ front end, zero share…
caugonnet 825d681
[STF] Python bundles: sparse CG example (the port cg.py couldn't be)
caugonnet 27e9971
[STF] Python bundles example: drop unused logical data (ruff F841)
caugonnet 99f0222
[STF] Python bundles: ctx.task() accepts bundle deps directly
caugonnet 6e52392
[STF] Python bundles: bundle views are namedtuples, one kernel argument
caugonnet fa12691
[STF] Python bundles: ctx.bundle() constructor
caugonnet 9df192e
[STF] Python bundles: fields must be logical data
caugonnet d30994e
[STF] Python bundles: document when NOT to use a bundle
caugonnet a7c3c4e
[STF] Python bundles: AccessMode.NONE excludes a field; docs correction
caugonnet d04ac17
[STF] Python bundles: stackable contexts get the same integration
caugonnet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the capabilities and constraints, but as a putative user I'd expect:
Also, having template deduction take care of things would be massively nicer:
auto graph = bundle(as_const(loffsets), as_const(lnonzeros));