[Dev] Preserve explicit NCCL NVLS configuration - #6319
Draft
lhb8125 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NCCL_NVLS_ENABLEto1only when the caller has not set itNCCL_NVLS_ENABLE=0or1from the launch environmentThis change is not required when a recipe always runs with NVLS enabled, but it is required for valid NVLS A/B experiments and for preserving caller-controlled NCCL semantics.
Test plan
CHECK_ONLY=true BASE_REF=dev uv run --no-sync --project /home/scratch.hongbinl_sw/work/fsdp/agentic-mcore-dev --extra mcore-lint -- bash tools/autoformat.shpython tools/check_copyright.py megatron/core/distributed/distributed_data_parallel.py tests/unit_tests/distributed/test_distributed_data_parallel.pyThe local toolkit environment does not contain PyTorch, so import-dependent pytest/mypy execution is deferred to the Megatron CI container.
🤖 Generated with Codex