[Dev] Make FSDP manual UBR registration deterministic - #6317
Draft
lhb8125 wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register_mem_pool, so a mismatch fails with diagnostics instead of hanging peersSymmetric registration requires matching collective registration order and pool-relative layouts across ranks. Lazy allocation during the first combined-1F1B/CUDA-Graph iteration allowed identical logical requests to receive different physical segment orderings on different ranks.
Stack
This Draft PR is stacked on #6316. After #6316 merges, this branch will be rebased onto
dev; the remaining diff is the singlefix(fsdp): make manual UBR registration deterministiccommit.Test plan
CHECK_ONLY=true BASE_REF=dev ... tools/autoformat.sh: Black, isort, pylint, and ruff passThe local toolkit lint environment does not contain PyTorch, so pytest and mypy imports are deferred to CI/container validation.
🤖 Generated with Codex