Skip to content

tests: Update cerno.yml with linear issue status - #6304

Open
balasaajay wants to merge 2 commits into
NVIDIA:mainfrom
balasaajay:update-cerno-1
Open

tests: Update cerno.yml with linear issue status#6304
balasaajay wants to merge 2 commits into
NVIDIA:mainfrom
balasaajay:update-cerno-1

Conversation

@balasaajay

@balasaajay balasaajay commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
  • I, the PR author, have personally reviewed every line of this PR.

What does this PR do?

Update cerno.yml with linear issue status and modify Dockerfile.linting commit reference

  • Added linear_issue_status: "Need Triage" to .gitlab/cerno.yml.
  • Updated CERNO_COMMIT in Dockerfile.linting from 5a5fb5360e67f8f09d189871bbc0d768c09c43fa to edda1ff3878c4722cdd51cccbebff1fa8fd63ebd.
  • Adjusted tests in test_ci_triage.py to reflect changes in configuration and commit reference.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact @NVIDIA/mcore-oncall.

Issue tracking

For PRs from open-source community contributors:

  • New features: a linked issue is required. Please open a feature request and reference it here before submitting the PR.
  • Small updates (bug fixes, minor improvements): a linked issue is recommended and will accelerate the PR review process.

Linked issue:

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

…ng commit reference

- Added `linear_issue_status: "Need Triage"` to `.gitlab/cerno.yml`.
- Updated `CERNO_COMMIT` in `Dockerfile.linting` from `5a5fb5360e67f8f09d189871bbc0d768c09c43fa` to `edda1ff3878c4722cdd51cccbebff1fa8fd63ebd`.
- Adjusted tests in `test_ci_triage.py` to reflect changes in configuration and commit reference.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay
balasaajay requested a review from a team as a code owner August 5, 2026 22:10
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft August 5, 2026 22:10
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@balasaajay
balasaajay marked this pull request as ready for review August 5, 2026 22:10
…r issue statuses

- Updated the assertion in `test_triage_config_selects_megatron_and_enables_write_actions` to streamline the check for `issue_statuses` by removing unnecessary line breaks.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants