chore(studio): set new defaults for feature flags - #1241
Merged
Conversation
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
Contributor
📝 WalkthroughWalkthroughChangesStudio feature-flag defaults and environment mappings were updated. Agent aggregate score handling now excludes scalar scores. The agent optimization flow was removed. Monitor and Virtual Models routes and navigation entries are now feature-gated. Studio configuration
Gated agent routes
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx (1)
14-15: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd disabled-state coverage for the feature-flag changes.
All three fixtures force the relevant flags on. They do not protect the default-off behavior described by PR
#1241.
web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx#L14-L15: Test disabledGUARDRAILS_ENABLEDandMONITOR_ENABLEDstates.web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx#L4-L6: Assert thatOpen tracesis absent when Monitor is disabled.web/packages/studio/src/routes/agents/CopilotChatRoute/studioUiNavigationSuggestions.test.ts#L23-L23: Assert that the agent-monitor suggestion is absent whenmonitorEnabledis false.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx` around lines 14 - 15, Extend the feature-flag tests to cover disabled defaults: in web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx lines 14-15, add coverage for disabled GUARDRAILS_ENABLED and MONITOR_ENABLED; in web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx lines 4-6, assert Open traces is absent when Monitor is disabled; and in web/packages/studio/src/routes/agents/CopilotChatRoute/studioUiNavigationSuggestions.test.ts lines 23-23, assert the agent-monitor suggestion is absent when monitorEnabled is false.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/api/evaluation/agent-evaluations.ts`:
- Around line 25-26: Update AgentEvalAggregateScore and aggregateScoresOf to
handle AggregateScalarScore results by reading their numeric value from value
rather than mean, while preserving existing range and rubric aggregation
behavior. Add a regression test covering scalar scores and verifying the
returned aggregate value is not null.
In `@web/packages/studio/src/api/evaluation/eval-config-fileset.ts`:
- Around line 29-30: Update the sample evaluation selection flow that uses
evalFilesetForAgent to ensure the corresponding <agentName>-eval fileset is
seeded before returning it. Invoke the existing ensureEvalConfigFileset path, or
create and upload the fileset through the established mechanism, while
preserving the current fileset naming contract.
---
Nitpick comments:
In `@web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx`:
- Around line 14-15: Extend the feature-flag tests to cover disabled defaults:
in web/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsx
lines 14-15, add coverage for disabled GUARDRAILS_ENABLED and MONITOR_ENABLED;
in web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx lines
4-6, assert Open traces is absent when Monitor is disabled; and in
web/packages/studio/src/routes/agents/CopilotChatRoute/studioUiNavigationSuggestions.test.ts
lines 23-23, assert the agent-monitor suggestion is absent when monitorEnabled
is false.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 38cabc69-5e5a-4773-807a-f21665b20b9e
📒 Files selected for processing (40)
services/studio/src/nmp/studio/env_mappings.pyweb/packages/studio/env/.env.dev.local.sampleweb/packages/studio/env/.env.fastapiweb/packages/studio/src/api/evaluation/agent-evaluations.tsweb/packages/studio/src/api/evaluation/eval-config-fileset.tsweb/packages/studio/src/components/agents/AgentBlockingInput/EvalConfigBlockingInput.tsxweb/packages/studio/src/components/dataViews/EvalComparisonTable/utils.test.tsweb/packages/studio/src/components/dataViews/EvalComparisonTable/utils.tsweb/packages/studio/src/components/dataViews/JobsDataView/index.test.tsxweb/packages/studio/src/constants/environment.tsweb/packages/studio/src/constants/featureFlags/featureFlags.tsweb/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.test.tsxweb/packages/studio/src/routes/WorkspaceLayout/WorkspaceSideNav.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsxweb/packages/studio/src/routes/agents/AgentMonitorRoute/index.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.read.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/AgentGroupSection.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/ApplyEvalConfigModal.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/EmptyState.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SectionHeading.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SeverityStat.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/StatColumn.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/StatsSection.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SuggestionTile.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/constants.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/index.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/types.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/useAgentOptimizations.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/useOptimizerSuggestions.test.tsxweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/useOptimizerSuggestions.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/utils.test.tsweb/packages/studio/src/routes/agents/AgentSuggestionsRoute/utils.tsweb/packages/studio/src/routes/agents/CopilotChatRoute/artifacts.tsweb/packages/studio/src/routes/agents/CopilotChatRoute/studioUiNavigationSuggestions.test.tsweb/packages/studio/src/routes/agents/CopilotChatRoute/studioUiNavigationSuggestions.tsweb/packages/studio/src/routes/groups/agentRoutes.tsxweb/packages/studio/src/routes/groups/virtualModelsRoutes.tsx
💤 Files with no reviewable changes (21)
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SectionHeading.tsx
- web/packages/studio/src/components/dataViews/EvalComparisonTable/utils.test.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/ApplyEvalConfigModal.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.test.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/StatsSection.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/EmptyState.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/index.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/AgentGroupSection.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SuggestionTile.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/utils.test.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/useAgentOptimizations.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.read.test.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/useOptimizerSuggestions.test.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/types.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/useOptimizerSuggestions.ts
- web/packages/studio/src/routes/agents/CopilotChatRoute/artifacts.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/StatColumn.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/constants.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/components/SeverityStat.tsx
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/api.ts
- web/packages/studio/src/routes/agents/AgentSuggestionsRoute/utils.ts
Contributor
|
Signed-off-by: Nicholas Kolean <nakolean@gmail.com>
steramae-nvidia
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-08-11.at.1.52.50.PM.mov
Guardrails (default: off) (includes virtual models)
Experiments (default: on)
Traces (default: on)
Data Designer (default: on)
Safe Synthesizer (default: on)
Filesets (default: on)
Deployments (default: off) (need to follow up on func, ticket to come)
Custom and Base Models (default: on)
Jobs (default: off)
Suggestions (delete page)
Monitor (default: off) (will feed into new Agent Entity page)
Evaluations (is moving to a tab in Agent Entity page)
Playground (is moving to models)
Summary
Related Issue
Changes
Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit
New Features
Bug Fixes
Removed