fix: avoid mutable default arguments in exp_manager timer callbacks - #15952
Open
andrewwhitecdw wants to merge 2 commits into
Open
fix: avoid mutable default arguments in exp_manager timer callbacks#15952andrewwhitecdw wants to merge 2 commits into
andrewwhitecdw wants to merge 2 commits into
Conversation
Signed-off-by: Andrew White <andrewh@cdw.com>
Contributor
Author
|
Could a maintainer please add the |
nithinraok
reviewed
Jul 27, 2026
svcnvidia-nemo-ci
added
the
waiting-on-customer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces mutable default arguments
{}withNoneinTimingCallbackandDeltaTimingCallback, then instantiates a fresh empty dict inside each constructor. This prevents shared state across instances if the dict is ever mutated.nemo/utils/exp_manager.py: changedtimer_kwargs={}totimer_kwargs: Optional[dict] = Nonefor both callbacksNoneTested:
uv run python -m pytest tests/core/test_exp_manager_timer_callbacks.py -v # 2 passedcc @nithinraok for core review