fix(asr): resolve CPU-GPU sync bottleneck in BLEU metric computation#15891
Open
Sainava wants to merge 2 commits into
Open
fix(asr): resolve CPU-GPU sync bottleneck in BLEU metric computation#15891Sainava wants to merge 2 commits into
Sainava wants to merge 2 commits into
Conversation
Signed-off-by: Sainava <sainava.modak@gmail.com>
Author
|
Hi , I noticed a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Resolves a documented$O(N)$ sequential metric update loop with an $O(1)$ batched update, eliminating implicit host-to-device synchronizations per sample.
TODOregarding excessive CPU-to-GPU operations by replacing anCollection: ASR
Changelog
BLEU_TOKENIZERextraction viacheck_cuts._bleu_score_updatecalls with a single group-level update, preventing thenumerator,denominator,preds_len, andtarget_lenstate tensors from forcing sequential CPU-GPU blocking during evaluation.Usage
# The BLEU metric is instantiated and used exactly as before, but evaluation throughput is significantly increased, especially at larger batch sizes.GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information
# TODO:on line 190 ofnemo/collections/asr/metrics/bleu.pyregarding backend implementation speedups.