feat: add support for CPU instruction#7
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the CPU instruction in nsL Assembler, which allows NSIS scripts to specify target CPU architectures. The implementation follows the existing pattern used by similar instructions like TargetInstruction.
Key changes:
- New CPUInstruction class that validates and assembles CPU architecture specifications
- Integration of CPUInstruction into the instruction matching logic in Statement.java
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/nsl/instruction/CPUInstruction.java | Implements the new CPU instruction with validation for x86 and amd64 architectures, context checking, and assembly logic |
| src/nsl/statement/Statement.java | Adds CPU instruction matching to the instruction parser to recognize and instantiate the new instruction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
idleberg
marked this pull request as ready for review
January 4, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.