NGWPC NWM PI-3 Formulation Selection Delivery 2026-02-25

[cmaynard-ngwpc]

This pull request integrates the EWTS logging framework across t-route, improving logging consistency, configurability, and test coverage. It introduces the troute_ewts package, migrates C and Python logging to named loggers, removes redundant initialization, and hardens environment-variable handling. The PR also makes a small functional improvement by exposing coastal coupling data loading for reuse.

---

Additions

• Added the troute_ewts package, including:
  • Module documentation/descriptions
  • Unit tests for EWTS functionality
• Added a named logger for t-route (Python and C code paths).
• Added a logger for t-route network C code, converting reservoir (RFC/hybrid) and levelpool outputs from printf to structured log entries.
• Exposed coastal coupling data loading outside assemble_forcings for broader reuse.

---

Changes

Logging & Configuration

• Updated to use the new EWTS package throughout t-route.
• Ensured EWTS initialization correctly reflects non-stale OS environment variables.
• Made NGEN_EWTS_LOGGING case-insensitive for more robust configuration.
• Removed an unnecessary configure_logging call to avoid redundant initialization.
• Standardized logging to named loggers, replacing ad-hoc or hardcoded outputs.

Code Quality & Tests

• Removed hardcoded strings from unit tests to improve maintainability.
• Updated .gitignore to ensure logging.c is built as part of the t-route network.
• Minor cleanups and consistency improvements aligned with EWTS adoption.

---

Removals

• Removed direct printf usage in favor of structured logging for reservoir-related code paths.
• Removed redundant logging configuration calls that were no longer needed with EWTS.