EDNS0 padding option support with DoT#494
Open
wtoorop wants to merge 2 commits into
Open
Conversation
Implementation + test package for RFC 7830, with the recommendations from RFC 8467 (i.e. pad responses with block size 468)
wcawijngaards
approved these changes
Jul 2, 2026
wcawijngaards
left a comment
wcawijngaards
left a comment
Member
There was a problem hiding this comment.
The code looks okay to me. I wanted to add a length and buffer capacity check when deciding on how much to pad. But the edns options section is already length checked, but then it can drop the pad but not other edns options.
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation + test package for RFC 7830,
with the recommendations from RFC 8467 (i.e. pad responses with block size 468)