Fix race on client tls-auth and tls-auth enhancements#490
Open
bilias wants to merge 2 commits into
Open
Conversation
cert-bundle and tls-auth certs can be outside of chroot and loaded before priv drop. Can be owned by root only. Client SSL CTX moved out of xfrd_tcp_set struct into tls_auth_options struct. CTXs for tls-auth are created before chroot. tp pipeline uses that to create the SSL connections. This also fixes a race on SSL CTX. Details: NLnetLabs#488
This was referenced Jun 8, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client SSL CTX moved out of xfrd_tcp_set struct into tls_auth_options struct.
CTXs for tls-auth are created before priv drop and before chroot (one CTX per tls-auth definition).
tp client pipeline re-uses the CTX template of tls-auth to create the SSL connections.
tls-cert-bundle,client-keyandclient-certowned by root only and outside of chroot as they are loaded before priv drop and before chrootSolves Read client certificates before dropping privileges #363
See Replace SSLv23 methods with TLS methods #487