Bug: Server should check only specific tls-auth#489
Open
bilias wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have a zone with multiple acls on provide-xfr with tls-auth like this:
server is checking ACLs independently of tls-auth.
So in this case, when secondary 2.3.4.5 (sec2.example.com) connects with tls-auth for zone transfer,
acl checks first for IP and tsig key. After that we have the SSL check.
Server searches first for
auth-domain-nameoftls-auth-1and it fails.Server should not check other tls-auth definitions.
If an IP is matched in a specific ACL, check that specific tls-auth that is defined in that specific ACL.
Effectively this is only a logic change (no code change) and we move the TLS AUTH check code inside
if(acl_addr_matches(acl, q) && acl_key_matches(acl, q)) {and not after it.