Uniform modal component#5741
Open
shatfield4 wants to merge 14 commits into
Open
Conversation
…op duplicate dark overlays
Collaborator
Author
|
Modal testing checklist:
|
…eat/uniform-modal-component
angelplusultra
requested changes
Jun 11, 2026
angelplusultra
left a comment
angelplusultra
left a comment
Contributor
There was a problem hiding this comment.
Nice job!
Just a couple nits but I tested 38 modal paths and everything seems to work great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #
Description
frontend/src/components/lib/Modal/index.jsxand migrates all app modals to it so every modal is visually uniform across light and dark modebg-theme-*CSS variables to explicitzinc(dark) /light:slate(light) color pairs from designsModalis the entrypoint: render it withisOpenandonClose, and pass whatever JSX you want as childrenModalprops:isOpen,onClose,size(sm400px /md500px /lg640px /xl868px, defaultmd),variant(defaultrenders the uniform card,barejust centers raw children for non-card modals like lightboxes),className(extra classes on the backdrop, e.g. a higherz-to clear a fixed top bar),closeOnEsc(default true), andnoPortal(render inline instead of portaling to#root)onClose; opt out per modal withcloseOnEsc={false}for flows that require a forced choiceModalHeader,ModalBody,ModalFooterModalHeadertakestitle, optionalsubtitle, andonClose(renders the close X when provided)ModalBodyis the unopinionated content region with standard field spacing; passclassNameto overrideModalFooteris the action row; it auto right-aligns when there is a single button and uses space-between when there are multipleModalPrimaryButton(Save/Create),ModalSecondaryButton(Cancel),ModalDangerButton(Delete) — all share the uniform sizing and just take normal button propsModalInputandModalTextarearender a label, the field, and an optional hint together; both acceptlabel,hint,optional, and forward the rest to the underlying input/textareaModalLabelandModalHintare available when you need just the label or hint on their ownsky-500on focus (no offset outline gap) in both light and dark modeVisuals (if applicable)
Additional Information
Developer Validations
yarn lintfrom the root of the repo & committed changes