Tests: Differentiate between Python 2 and Python 3 saves#144
Merged
Conversation
Contributor
Author
|
I remembered that World_pb2.py now supposedly is the same for Python 2 and 3. Is that right? And if so: Well...maybe we don't need separate pickle-files? Since I can't use the Python 2-version of Worldengine I also can't check what it would output and if the files maybe are the same. |
Member
|
protobuf solves the python2/3 problem (one file fits all), but only for protobuf worlds. :) |
Contributor
Author
|
Oh, I'm an idiot. Disregard my last comment.^^ (I was thinking about pickle and somehow mixed the protobuf file in, and then thought "Hey, maybe the problem is non-existent?".) |
psi29a
added a commit
that referenced
this pull request
Oct 20, 2015
Tests: Differentiate between Python 2 and Python 3 saves
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is ok, I will follow up with an update to my PR at worldengine-data.
Mindwerks/worldengine-data#1