Replaced PhreeqcRM interface ctypes with phreeqcrm pip package - #39
Replaced PhreeqcRM interface ctypes with phreeqcrm pip package#39matteomasi wants to merge 7 commits into
Conversation
…g in pytest configuration.
|
raar1
left a comment
There was a problem hiding this comment.
Good work @matteomasi ! Sorry for the late review. This is a big improvement as maintaining the wrapper for the phreeqc binaries was always going to be a bit of a maintenance nightmare, so it's good to see a separate pypi package for it.
I'm not too sure about the testing, currently, as it seems to me to largely be testing a mock of phreeqc rather than functionality of mibiremo (probably because we just moved a lot of functionality to the new package). We could have a call in Aug or Sep maybe to discuss some ideas (I think @JaroCamphuijsen and I had a few regarding using mibiremo + mibitrans)



mibiremo/phreeqc.pyhas been rewritten to wrap the phreeqcrm pip package instead of using ctypes. PhreeqcRM no longer depends on compiled libraries (previously bundled with themibiremopackage itself), and instead always stays up to date with thephreeqcrmpip package.phreeqcrmdependency inpyproject.toml