Skip to content

Replaced PhreeqcRM interface ctypes with phreeqcrm pip package - #39

Open
matteomasi wants to merge 7 commits into
mainfrom
34-replace-ctypes-phreeqcrm-interface-with-phreeqcrm-pip-package
Open

Replaced PhreeqcRM interface ctypes with phreeqcrm pip package#39
matteomasi wants to merge 7 commits into
mainfrom
34-replace-ctypes-phreeqcrm-interface-with-phreeqcrm-pip-package

Conversation

@matteomasi

Copy link
Copy Markdown
Collaborator
  • The core module mibiremo/phreeqc.py has been rewritten to wrap the phreeqcrm pip package instead of using ctypes. PhreeqcRM no longer depends on compiled libraries (previously bundled with the mibiremo package itself), and instead always stays up to date with the phreeqcrm pip package.
  • Added phreeqcrm dependency in pyproject.toml
  • Updated tests and examples

@matteomasi
matteomasi requested a review from raar1 April 10, 2026 12:00
@matteomasi matteomasi linked an issue Apr 10, 2026 that may be closed by this pull request
@sonarqubecloud

Copy link
Copy Markdown

@raar1 raar1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @matteomasi ! Sorry for the late review. This is a big improvement as maintaining the wrapper for the phreeqc binaries was always going to be a bit of a maintenance nightmare, so it's good to see a separate pypi package for it.

I'm not too sure about the testing, currently, as it seems to me to largely be testing a mock of phreeqc rather than functionality of mibiremo (probably because we just moved a lot of functionality to the new package). We could have a call in Aug or Sep maybe to discuss some ideas (I think @JaroCamphuijsen and I had a few regarding using mibiremo + mibitrans)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

Replace ctypes PhreeqcRM interface with phreeqcrm pip package

3 participants