feat: add tab navigation for limit and recurring orders - #34824
Open
GeorgeGkas wants to merge 3 commits into
Open
feat: add tab navigation for limit and recurring orders#34824GeorgeGkas wants to merge 3 commits into
GeorgeGkas wants to merge 3 commits into
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ed550a7. Configure here.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Upcoming Swap/Bridge features (Limit Order and Recurring Buy) need a shared entry point alongside the existing market-order flow. This PR introduces a tab-based navigation shell in
BridgeViewand moves the current swap/bridge UI into a dedicatedBridgeMarketView, leaving placeholder views for the WIP Limit and Recurring tabs.Reason: The swaps team is building Limit Order and Recurring Buy on top of the existing Bridge screen. A tab system is required to host those flows without duplicating header, navigation, and lifecycle logic.
Solution:
BridgeViewinto a lightweight tab container withTabsBar, swipe gestures, and deferred content rendering viastartTransitionfor smoother tab presses.BridgeMarketView(including footer, styles, and utils renames).BridgeLimitOrderViewandBridgeRecurringBuyViewas placeholder containers behind remote feature flags (swapsLimitOrder,swapsRecurringBuy) with local env overrides (MM_BRIDGE_LIMIT_ORDER_TAB_ENABLED,MM_BRIDGE_RECURRING_BUY_TAB_ENABLED).Changelog
CHANGELOG entry: null
Related issues
Refs: https://consensyssoftware.atlassian.net/browse/SWAPS-4943
Manual testing steps
Screenshots/Recordings
Before
N/A
After
N/A — screenshots recommended when validating with WIP feature flags enabled (tabs bar visible with Market / Limit / Recurring labels).
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Localized Bridge navigation UX and gesture wiring with unit tests; no swap execution, auth, or data-layer changes.
Overview
Bridge tab content now responds to horizontal swipes: left moves to the next tab (when one exists), right moves to the previous tab, and a right swipe on the first tab calls
goBack(including when only Market is shown and the tabs bar is hidden).The pan handler is on a
GestureDetectoraround the tab body, with thresholds on translation/velocity andscheduleOnRNso tab changes run on the JS thread. New test IDs support gesture tests viareact-native-gesture-handler/jest-utils.Navigation: the Bridge stack screen sets
gestureEnabled: falseon top ofslideFromRightNativeOptionsso the OS back-swipe does not fight in-screen tab swipes.Reviewed by Cursor Bugbot for commit c7803f1. Bugbot is set up for automated code reviews on this repo. Configure here.