Skip to content

chore: remove orphaned fullPageAccountList feature flag selector - #34809

Open
javiergarciavera wants to merge 1 commit into
mainfrom
chore/remove-fullPageAccountList-dead-flag
Open

chore: remove orphaned fullPageAccountList feature flag selector#34809
javiergarciavera wants to merge 1 commit into
mainfrom
chore/remove-fullPageAccountList-dead-flag

Conversation

@javiergarciavera

@javiergarciavera javiergarciavera commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

The selectFullPageAccountListEnabledFlag selector was created in Dec 2025 as part of a useFeatureFlag migration but was never consumed by any component or hook. Zero imports exist outside the selector directory itself.

Removes:

  • app/selectors/featureFlagController/fullPageAccountList/ (selector + test)
  • FeatureFlagNames.fullPageAccountList enum entry in constants/featureFlags.ts

Description

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dead-code removal only; no consumers of the selector existed in app code.

Overview
Removes dead code for the fullPageAccountList remote flag: the version-gated selector module (selectFullPageAccountListEnabledFlag and its tests) and the matching FeatureFlagNames.fullPageAccountList dev-override entry.

Nothing in the app imported this selector, so runtime behavior is unchanged; this is cleanup after an unused useFeatureFlag migration path.

Reviewed by Cursor Bugbot for commit e30c2c2. Bugbot is set up for automated code reviews on this repo. Configure here.

The selectFullPageAccountListEnabledFlag selector was created in Dec 2025
as part of a useFeatureFlag migration but was never consumed by any
component or hook. Zero imports exist outside the selector directory itself.

Removes:
- app/selectors/featureFlagController/fullPageAccountList/ (selector + test)
- FeatureFlagNames.fullPageAccountList enum entry in constants/featureFlags.ts
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Aug 14, 2026
@metamask-ci metamask-ci Bot added the team-qa QA team label Aug 14, 2026
@metamask-ci

metamask-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Blocking — these items fail the workflow until fixed:

  • Changelog section has an empty CHANGELOG entry: line. Fill in a description, write CHANGELOG entry: null, or apply the no-changelog label.

Warnings — informational, address before merging:

  • Description section is empty. Describe what changed and why.
  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.
  • Manual testing steps still contain template content (the Gherkin example title or a [...] placeholder). Replace with real steps, or write N/A — <reason>.
  • Screenshots/Recordings section is empty. Add an image/video for user-facing changes, logs/console output for non-user-facing changes, or write N/A if no evidence is applicable.
  • Pre-merge author checklist has unchecked items (e.g. "I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards."). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions github-actions Bot added size-M risk:medium AI analysis: medium risk labels Aug 14, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. risk:medium AI analysis: medium risk size-M team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant