chore: remove orphaned fullPageAccountList feature flag selector - #34809
Open
javiergarciavera wants to merge 1 commit into
Open
chore: remove orphaned fullPageAccountList feature flag selector#34809javiergarciavera wants to merge 1 commit into
javiergarciavera wants to merge 1 commit into
Conversation
The selectFullPageAccountListEnabledFlag selector was created in Dec 2025 as part of a useFeatureFlag migration but was never consumed by any component or hook. Zero imports exist outside the selector directory itself. Removes: - app/selectors/featureFlagController/fullPageAccountList/ (selector + test) - FeatureFlagNames.fullPageAccountList enum entry in constants/featureFlags.ts
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
PR template — items to address before "Ready for review"Blocking — these items fail the workflow until fixed:
Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The selectFullPageAccountListEnabledFlag selector was created in Dec 2025 as part of a useFeatureFlag migration but was never consumed by any component or hook. Zero imports exist outside the selector directory itself.
Removes:
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Dead-code removal only; no consumers of the selector existed in app code.
Overview
Removes dead code for the
fullPageAccountListremote flag: the version-gated selector module (selectFullPageAccountListEnabledFlagand its tests) and the matchingFeatureFlagNames.fullPageAccountListdev-override entry.Nothing in the app imported this selector, so runtime behavior is unchanged; this is cleanup after an unused
useFeatureFlagmigration path.Reviewed by Cursor Bugbot for commit e30c2c2. Bugbot is set up for automated code reviews on this repo. Configure here.