Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
Matt561
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
This PR upgrades to the final version of the money account upgrade controller - which can in theory run through the entire chomp upgrade flow.
Things that we've changed in this PR in addition to bumping the package
TODO
We need to merge and publish this core pr and update the preview packages that are currently used in this branch to the real published updates.Changelog
CHANGELOG entry: Update to final version of money account upgrade controller
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
High Risk
High risk because it changes on-chain transaction construction (deposit/withdraw asset address selection) and rewires the Money Account upgrade bootstrap to auto-add networks and use a new controller init contract, which can break upgrade/deposit flows if config or chain data is wrong.
Overview
Money Account upgrade bootstrapping is refactored to match the new
@metamask/money-account-upgrade-controllerAPI: initialization now readschainId/boringVaultfrom themoneyAccountVaultConfigfeature flag (instead of CHOMP service details + DeleGator env) and passes a new object payload tocontroller.init.Adds a pre-init guard to ensure the vault chain exists in
NetworkController: if missing, it auto-adds the chain fromPopularList(with explicit error handling when not found), and corresponding unit tests were updated/expanded.Moves Money Account deposit asset selection to mUSD:
getMoneyAccountDepositAssetAddressnow resolves viaMUSD_TOKEN_ADDRESS_BY_CHAIN(throwing if absent) rather than using a temporary hardcoded USDC address, and mUSD constants/config were extended for Monad (addresses/asset IDs) along with updated dev vault config + dependency bumps (money-account-upgrade-controllerandchomp-api-service).Reviewed by Cursor Bugbot for commit 2b4cc57. Bugbot is set up for automated code reviews on this repo. Configure here.