feat: implement rich notification setting config using AUS#8784
Open
baptiste-marchand wants to merge 11 commits into
Open
feat: implement rich notification setting config using AUS#8784baptiste-marchand wants to merge 11 commits into
baptiste-marchand wants to merge 11 commits into
Conversation
…notification flags
…flag and improve wallet activity account handling
a279ae9 to
ab7bf53
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b01857c. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
References
Checklist
Note
High Risk
High risk because it replaces the source of truth for notification enablement from Trigger API config to Authenticated User Storage, changing initialization and enable/disable flows and introducing breaking option/type changes that can affect user notification state.
Overview
Switches notification settings to Authenticated User Storage (AUS) as the source of truth.
NotificationServicesControllernow reads/writes AUSNotificationPreferencesvia new required messenger actions, and derives enabled accounts for push + on-chain notification fetching fromwalletActivity.accountsrather than Trigger API config.Adds first-time preference initialization and new options. When AUS preferences are missing (
null),createOnChainTriggersseeds a full preferences blob (wallet activity seeded from Trigger API state with “enable all” first-time fallback; marketing seeded fromhasMarketingConsentand newproductAnnouncementEnabled; perps/social defaults added). The unusedresetNotificationsoption is removed (breaking).Updates types/tests/mocks accordingly.
@metamask/authenticated-user-storagenotification preference fields replaceenabledwithinAppNotificationsEnabled/pushNotificationsEnabled, and Trigger API “update notifications” code/tests are removed in favor of AUS writes; package build references and exports are updated to include the new defaults.Reviewed by Cursor Bugbot for commit beb3870. Bugbot is set up for automated code reviews on this repo. Configure here.