Skip to content

feat: implement rich notification setting config using AUS#8784

Open
baptiste-marchand wants to merge 11 commits into
mainfrom
GE-13-integrating-AUS-with-notification-setting
Open

feat: implement rich notification setting config using AUS#8784
baptiste-marchand wants to merge 11 commits into
mainfrom
GE-13-integrating-AUS-with-notification-setting

Conversation

@baptiste-marchand
Copy link
Copy Markdown
Contributor

@baptiste-marchand baptiste-marchand commented May 13, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
High risk because it replaces the source of truth for notification enablement from Trigger API config to Authenticated User Storage, changing initialization and enable/disable flows and introducing breaking option/type changes that can affect user notification state.

Overview
Switches notification settings to Authenticated User Storage (AUS) as the source of truth. NotificationServicesController now reads/writes AUS NotificationPreferences via new required messenger actions, and derives enabled accounts for push + on-chain notification fetching from walletActivity.accounts rather than Trigger API config.

Adds first-time preference initialization and new options. When AUS preferences are missing (null), createOnChainTriggers seeds a full preferences blob (wallet activity seeded from Trigger API state with “enable all” first-time fallback; marketing seeded from hasMarketingConsent and new productAnnouncementEnabled; perps/social defaults added). The unused resetNotifications option is removed (breaking).

Updates types/tests/mocks accordingly. @metamask/authenticated-user-storage notification preference fields replace enabled with inAppNotificationsEnabled/pushNotificationsEnabled, and Trigger API “update notifications” code/tests are removed in favor of AUS writes; package build references and exports are updated to include the new defaults.

Reviewed by Cursor Bugbot for commit beb3870. Bugbot is set up for automated code reviews on this repo. Configure here.

@baptiste-marchand baptiste-marchand force-pushed the GE-13-integrating-AUS-with-notification-setting branch from a279ae9 to ab7bf53 Compare May 13, 2026 09:38
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit b01857c. Configure here.

@baptiste-marchand baptiste-marchand changed the title feat: integrating AUS with notification setting feat: implement rich notification setting config using AUS May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant