feat(snap-account-service): add getLegacySnapKeyring#8757
Open
ccharly wants to merge 7 commits into
Open
Conversation
getLegacySnapKeyring
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f222f71. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Add a
getLegacySnapKeyringto replace all use ofgetSnapKeyringin each clients.References
N/A
Checklist
Note
Medium Risk
Adds a new messenger-exposed method that can create a legacy Snap keyring via
KeyringController:withController, which touches keyring management and could impact account/keyring state if misused. Scope is otherwise contained to the snap-account-service package with dedicated tests.Overview
Adds a new
SnapAccountService:getLegacySnapKeyringmessenger action that atomically returns the existing legacy Snap keyring (KeyringTypes.snap) or creates it viaKeyringController:withController/addNewKeyring, with logging when creation occurs.Updates action type unions and tests to cover existing-keyring, create-if-missing, and error propagation behavior, and adds
@metamask/eth-snap-keyring(plus@metamask/keyring-utilsfor typing) dependencies alongside changelog entries.Reviewed by Cursor Bugbot for commit 74136a7. Bugbot is set up for automated code reviews on this repo. Configure here.