feat(snap-account-service): add migration logic + keyring v2 support#8732
Open
ccharly wants to merge 11 commits into
Open
feat(snap-account-service): add migration logic + keyring v2 support#8732ccharly wants to merge 11 commits into
ccharly wants to merge 11 commits into
Conversation
ccharly
force-pushed
the
cc/feat/snap-account-service-keyring-v2-support
branch
from
96269d0 to
43c238b
Compare
ccharly
changed the base branch from
main
to
cc/feat/snap-account-service-account-group-events
ccharly
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ccharly
force-pushed
the
cc/feat/snap-account-service-keyring-v2-support
branch
from
8452267 to
ce71df1
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2adb638. Configure here.
Base automatically changed from
cc/feat/snap-account-service-account-group-events
to
main
May 12, 2026 19:50
ccharly
force-pushed
the
cc/feat/snap-account-service-keyring-v2-support
branch
from
a4b5e03 to
47199fa
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Add migration logic to migrate from the legacy Snap keyring to the new architecture with 1 Snap keyring v2 per Snaps.
Also enhance
:ensureReadyso consumers can safely call:withKeyringV2to get the associated Snap keyring v2 instance before using it.References
N/A
Checklist
Note
High Risk
High risk because it changes Snap keyring lifecycle/selection and introduces automatic migration + keyring creation in
ensureReady, affecting account management, message routing, and selected-account forwarding.Overview
Implements a legacy → per-Snap v2 keyring migration in
SnapAccountService(migrate) and makesensureReadyrun it, then auto-create a v2 Snap keyring for the requested Snap when missing.Switches
handleKeyringSnapMessageand selected-account forwarding to target v2 Snap keyrings (including aGetSelectedAccountsfast-path filtered by keyring ownership), adds new messenger dependencies (withKeyringV2/withKeyringV2Unsafe), and updates multichain Snap providers/tests to useKeyringController:withKeyringV2and v2 Snap keyring APIs (createAccountssignature changes,removeAccount→deleteAccount, selector filtering bysnapId).Reviewed by Cursor Bugbot for commit f462720. Bugbot is set up for automated code reviews on this repo. Configure here.