-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add BEXChain assets and metadata (Chain ID 140586) #1835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bexchainteam
wants to merge
24
commits into
MetaMask:master
Choose a base branch
from
bexchainteam:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 14 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
d2fd8ad
Create eip155:140586
bexchainteam ceaed4e
Delete metadata/eip155:140586
bexchainteam 0d908e6
Add new metadata for EIP-155 chain
bexchainteam f5b828e
Delete metadata/eip155:140586
bexchainteam fbef279
Add JSON metadata for USDT token
bexchainteam 92ed497
Add metadata for USDB ERC20 token
bexchainteam 7cdf73b
Update erc20:0x3f1c8a5244a8959116e6e01df5e13847b7e11726.json
bexchainteam 02c3d4a
Update token metadata for USDT
bexchainteam be26d96
Add metadata for ERC20 token ONE
bexchainteam 060f35a
Create erc20:0xbc6593358feea849a059fe2c8bcb48d138abee50.svg
bexchainteam 4d88b2b
Delete icons/eip155:140586/erc20:0xbc6593358feea849a059fe2c8bcb48d138…
bexchainteam e13798e
Add files via upload
bexchainteam dde800a
Update metadata for ERC20 token
bexchainteam df0dc23
Rename JSON file for ERC20 token metadata
bexchainteam 4c13003
Fix logo casing in JSON metadata
bexchainteam af87842
Add files via upload
bexchainteam 306a306
Delete icons/eip155:140586/erc20:0xbc6593358feea849a059fe2c8bcb48d138…
bexchainteam 4e52920
Delete icons/eip155:140586/erc20:0x3f1c8a5244a8959116e6e01df5e13847b7…
bexchainteam d1967b2
Delete icons/eip155:140586/erc20:0x635bdb62f35e1971b96fb9609cbdd2dab4…
bexchainteam 9e08141
Add files via upload
bexchainteam ab8f1c7
Delete icons/eip155:140586/erc20:0x3f1C8A5244A8959116e6E01df5e13847B7…
bexchainteam b211e9b
Delete icons/eip155:140586/erc20:0x635bDB62f35E1971b96fB9609cbdD2daB4…
bexchainteam 6528d00
Delete icons/eip155:140586/erc20:0xBc6593358feEa849A059fE2C8bcB48d138…
bexchainteam 075faf0
Add files via upload
bexchainteam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+220 KB
icons/eip155:140586/erc20:0x3f1c8a5244a8959116e6e01df5e13847b7e11726.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.74 MB
icons/eip155:140586/erc20:0x635bdb62f35e1971b96fb9609cbdd2dab4fa91fe.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+15.9 KB
icons/eip155:140586/erc20:0xbc6593358feea849a059fe2c8bcb48d138abee50.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions
7
metadata/eip155:140586/erc20:0x3f1C8A5244A8959116e6E01df5e13847B7e11726.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name": "USDB", | ||
| "symbol": "USDB", | ||
| "decimals": 18, | ||
| "erc20": true, | ||
| "logo": "./icons/eip155:140586/erc20:0x3f1C8A5244A8959116e6E01df5e13847B7e11726.svg" | ||
| } | ||
7 changes: 7 additions & 0 deletions
7
metadata/eip155:140586/erc20:0x635bdb62f35e1971b96fb9609cbdd2dab4fa91fe.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name": "ONE", | ||
| "symbol": "ONE", | ||
| "decimals": 18, | ||
| "erc20": true, | ||
| "logo": "./icons/eip155:140586/erc20:0x635bdb62f35e1971b96fb9609cbdd2dab4fa91fe.svg" | ||
| } |
7 changes: 7 additions & 0 deletions
7
metadata/eip155:140586/erc20:0xBc6593358feEa849A059fE2C8bcB48d138ABee50.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| { | ||
| "name": "USDT", | ||
| "symbol": "wUSDT", | ||
| "decimals": 18, | ||
| "erc20": true, | ||
| "logo": "./icons/eip155:140586/erc20:0xBc6593358feEa849A059fE2C8bcB48d138ABee50.svg" | ||
|
cursor[bot] marked this conversation as resolved.
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
USDB logo path mismatch
Medium Severity
The
logofield points at a checksummed SVG filename undericons/eip155:140586, but the repo only has the same asset icon stored with an all-lowercase address in the filename. On case-sensitive filesystems and typical raw GitHub URLs, that path does not resolve, so USDB’s logo fails to load and the metadata logo existence check intest/caip.jscan fail.Reviewed by Cursor Bugbot for commit dde800a. Configure here.