Add land mask to sterodynamic component#69
Open
Hemant Khatri (hmkhatri) wants to merge 3 commits into
Open
Conversation
Collaborator
Author
Greg Munday (gregrmunday)
approved these changes
Jun 13, 2026
Greg Munday (gregrmunday)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Hemant, looks good to me! Just wanted to double check that you're happy with the padding/longitudinal alignment of the masks?
Can see in the figure up top that the funnel-y artefacts from the ocean grids aren't in the same place - is this expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This pull request add land mask. It reads in all available land masks and applies the union of those land masks to all models. The union is required because some model have weird land mask or not have at all.
Advantage of this approach is that only ocean grid points present in all models are considered. The downside is that some of the grid points near the continental boundaries are lost (see figure).
The sterodynamic output has nans over land. The code does not affect other other components, which have data over the whole globe.
Greg Munday (@gregrmunday) Could you please review it?