Skip to content

Add Local model for site-specific projections#68

Open
Greg Munday (gregrmunday) wants to merge 11 commits into
profsea-v3from
gm/add-timeseries-module
Open

Add Local model for site-specific projections#68
Greg Munday (gregrmunday) wants to merge 11 commits into
profsea-v3from
gm/add-timeseries-module

Conversation

@gregrmunday

@gregrmunday Greg Munday (gregrmunday) commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Does what it says on the tin! Same use as the Spatial projections class but the user provides a set of site and lat/lons.

Closes #66

@hmkhatri

Copy link
Copy Markdown
Collaborator

Greg Munday (@gregrmunday) thanks for the pull request. Need to think about interpolation around boundaries. I am working on land mask issue and interpolation with land mask. Maybe better to merge that first and then review this pull request.

@gregrmunday

Copy link
Copy Markdown
Collaborator Author

Greg Munday (Greg Munday (@gregrmunday)) thanks for the pull request. Need to think about interpolation around boundaries. I am working on land mask issue and interpolation with land mask. Maybe better to merge that first and then review this pull request.

Sounds good to me! I'll have a think about how we can handle this too. I feel like we should think carefully about this and not being too prescriptive with flags/warnings/exceptions, but somehow still return something sensible if they give us tricky grid-boxes...

@gregrmunday Greg Munday (gregrmunday) linked an issue Jun 14, 2026 that may be closed by this pull request
@gregrmunday

Greg Munday (gregrmunday) commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator Author

Hemant Khatri (@hmkhatri) This is ready for review! I've handled propagating the masking slightly differently than you, but made sure to always pick the "nearest" during interpolation and then I've updated both the Local and Spatial models to sum using skipna=False, just to make sure the final total sea-level at the coast isn't missing the thermal expansion component.

See the tutorial notebook on how to use the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SLR timeseries at specific lat-lon location

2 participants