Android GUI: Changes for minSDK >= 23 - #1279
Conversation
7d15236 to
eb7a4d9
Compare
|
Great!
It would be great to have a simpler code here and all with the same style, if you find a way... I know, I ask a lot. |
|
And I thought
I was thinking making it expand and shrink on scroll where it shows some text next to it. Like the buttons in Google's apps. |
It works great now and with amazing and smooth animations when list is updated. Also maintains position of list on navigation. Previously it wasn't very efficient with adapter being recreated on navigation/add and not letting native code handle the list. |
4799520 to
39d8b7f
Compare
|
Looks like that's all for now. Updated screenshots above. Unable to use native shape/color changing (https://github.com/material-components/material-components-android/blob/master/docs/components/List.md#listitemcardview-attributes) for currently selected item; the colour manually toggled with XML and shape no change. Preferences seems difficult as PreferenceScreen is not updated to new style so may need to migrate the entire thing to ListItemCardView to make it look like new Android system settings style. |
6b8e0e2 to
d9ff531
Compare
|
Since @JeromeMartinez said "Note: it would be also nice to have that with the Android UI", added the initial libcurl support to the Android GUI. At the moment can only share from other apps, somewhat similar to Windows GUIs where it can be passed via command line but no GUI for inputting URLs yet. Screen_recording_20260518_192357.webmNot thoroughly tested and have not checked size impact yet. Note Requires changes to MediaInfoLib's CMake (that are in the android-lib PR) to detect and link with libcurl Side note: enabling libcurl require enabling reader to work then after that requires enabling sha2 which then requires enabling md5 in order to build successfully with |
Thank you!
Not a bid deal.
this would be a concern, but checking libcurl size it seems acceptable (0.5 MB compressed per arch?). I like to have things as small as possible but it is not like if MediaInfo is huge.
Acceptable, but you can add MEDIAINFO_FILE_NO and MEDIAINFO_DIRECTORY_NO, not needed.
I have a concern here, it is outdated by few months (2 new versions in the meanwhile), but at longer term we could use our own build for also being safer. |
I cannot find a more official/reliable curl for Android. Anyway, all the build scripts are on GitHub for this one so we probably can update it and build it ourselves for more reliability, control and security.
Isn't the libcurl for the MediaInfo Windows releases way older than this? 😅 |
Something I am not proud about, I need to update that more often. |
Since it is from vcpkg, maybe can script an automated build whenever new version is available. Same with Graphviz. Can build including ARM64 from vcpkg. |
I could accept such automation ;-). |
|
Disabled FILE (DIRECTORY was already disabled) and also managed to exclude MD5 which requires fix in MediaInfoLib so made a new PR there. |
Seems libmediainfo.so increased 2MiB uncompressed. By increasing minSDK to 23, native libraries are now uncompressed in APK to allow direct loading without extraction. This results in smaller install size due to no duplicate from extraction. Play Store will compress the transfer so download size is fine. Just that APK file size will be larger. |
@JeromeMartinez Example of automated libcurl build: https://github.com/cjee21/libcurl-Windows. Can integrate this with one of MediaArea's repository. Then in build/packaging CI, can fetch latest from a fixed URL like mentioned in the readme. |
https://github.com/MediaArea/libcurl-Windows |
|
There is a bug, opening a url after a file, MediaInfo shows the previous filename as complete name instead of the url. Update: Solved by resetting File_FileName before opening urls. |

This PR contains updates and improvements that can be made when minSDK is increased to 23.