Skip to content

configurable language for fulltext-search#2133

Open
blued-gear wants to merge 7 commits into
mainfrom
new/ts-lang_server_setting
Open

configurable language for fulltext-search#2133
blued-gear wants to merge 7 commits into
mainfrom
new/ts-lang_server_setting

Conversation

@blued-gear
Copy link
Copy Markdown
Collaborator

closes #2043

@blued-gear blued-gear self-assigned this May 6, 2026
@blued-gear blued-gear added documentation Improvements or additions to documentation enhancement New feature or request backend Backend related issues and pull requests labels May 6, 2026
@BentiGorlich
Copy link
Copy Markdown
Member

I love that you're tackling this ❤️

I am not sure what the default should be. I guess you used English as it is the current behaviour, but would it be possible to set it to "generic" or something like that, that is not language specific?

Comment thread .env.example_docker
S3_ENDPOINT=
S3_VERSION=

# Only let admins generate oauth clients
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These KBIN_* options are still in use. Keep it in the example. right? Eventually we might need to rename all the configs with MBIN_ so its all consistent. but that is unrelated to this PR.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are in the file, I just deleted duplicated keys (see lines 52+).

@blued-gear
Copy link
Copy Markdown
Collaborator Author

I guess you used English as it is the current behaviour, but would it be possible to set it to "generic" or something like that, that is not language specific?

While I'm not fully against it, I prefer to have English as the default for the following reasons:

  • most instances are English centered
  • if set to English most instances would have to manually migrate to English search after the update to keep their current search behavior. Two such migrations can waste a lot of CPU time when the DB recreates the indexes.
  • as the configuration is part of the setup docs for the admins, new instance admins won't miss the option for optimizing their search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Backend related issues and pull requests documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Full-text search is hardcoded to English, breaking search for non-English instances

3 participants