fix: skip TLS hostname verification when rejectUnauthorized=false - #86
Merged
SanjulaGanepola merged 8 commits intoJul 17, 2026
Conversation
rejectUnauthorized=false already skipped certificate chain validation but Java-WebSocket still enabled HTTPS endpoint identification, causing SAN mismatches to fail. overrides onSetSSLParameters to clear endpoint identification when rejectUnauthorized is false Signed-off-by: Wyatt Mogelson <wyattmog@icloud.com>
8 tasks
Member
|
@wyattmog Thanks for the change, I can review and merge this tomorrow |
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
SanjulaGanepola
had a problem deploying
to
OSSBUILD
July 17, 2026 16:02 — with 
GitHub Actions
Failure
GitHub Actions
Failure
SanjulaGanepola
approved these changes
Jul 17, 2026
SanjulaGanepola
left a comment
SanjulaGanepola
left a comment
Member
There was a problem hiding this comment.
@wyattmog Changes look good. Thanks
SanjulaGanepola
had a problem deploying
to
OSSBUILD
July 17, 2026 16:16 — with
GitHub Actions
Failure
GitHub Actions
Failure
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
SanjulaGanepola
had a problem deploying
to
OSSBUILD
July 17, 2026 16:23 — with
GitHub Actions
Failure
GitHub Actions
Failure
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
SanjulaGanepola
had a problem deploying
to
OSSBUILD
July 17, 2026 16:29 — with
GitHub Actions
Failure
GitHub Actions
Failure
Signed-off-by: Sanjula Ganepola <Sanjula.Ganepola@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to ibmi-mcp-server-lite#17
rejectUnauthorized=falsenow skips TLS hostname verification in addition to certificate chain validation. motivated by TLS hostname verification in ibmi-mcp-server-lite: users settingignore-unauthorized: trueexpect full TLS relaxation during development/self-signed cert scenarios, but connections still failed withNo subject alternative names matching ...when the connect host did not match the Mapepire certificate SAN (DNS alias, loopback name, or IP).Changes
SqlJob- overrideonSetSSLParameterson theWebSocketClientingetChannel(); whenrejectUnauthorized=false, clearendpointIdentificationAlgorithm; whentrue(default), callsuper.onSetSSLParameters()so HTTPS hostname verification stays enabledConnectTest-rejectUnauthorizedFalseConnectsWhenCertificateDoesNotMatchHost(connect via resolved IP withrejectUnauthorized=false; expects success)ConnectTest-rejectUnauthorizedTrueFailsWhenCertificateDoesNotMatchHost(same SAN mismatch withrejectUnauthorized=true+ pinned CA; expects hostname verification failure)Testing