[Experimental] Fix regression tests in test_vectorized_mobject.py - #4922
Open
fmuenkel wants to merge 1 commit into
Open
[Experimental] Fix regression tests in test_vectorized_mobject.py#4922fmuenkel wants to merge 1 commit into
test_vectorized_mobject.py#4922fmuenkel wants to merge 1 commit into
Conversation
test_vectorized_mobject.py
test_vectorized_mobject.pytest_vectorized_mobject.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Refactors the regression test to check incomplete curves for the OpenGL renderer, which uses 3 point (quadratic) bezier curves instead of Cairo's 4 point (cubic) curves. Reames the test function
test_align_points_handles_vmobject_with_no_complete_cubic_curvestotest_align_points_handles_vmobject_with_no_complete_curvesMake
Iterableavailable at runtime, which fixestest_vgroup_init_with_iterable.Motivation and Explanation: Why and how do your changes improve the library?
The test treated three point curves as incomplete, which is not the case for the OpenGL renderer.
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist