Point README examples at the manifests that exist - #53
Merged
Conversation
MPV
force-pushed
the
claude/docs-examples
branch
from
July 23, 2026 06:45
c743a1d to
cd1a076
Compare
MPV
changed the title
The usage section referenced an examples/ directory that was never in the repo, so every documented command failed for anyone following along. Rather than add a duplicate set of manifests, point the commands at the existing approval-test fixtures under approvals/, which are the canonical sample manifests. Their outputs match what the README documents: the StatefulSet fixture prints the three listed images, and `kir_test.TestKind.*.input.yaml | sort -u` prints the listed seven. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC
MPV
force-pushed
the
claude/docs-examples
branch
from
July 23, 2026 06:48
cd1a076 to
3ebd892
Compare
MPV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the README's usage section, which referenced an
examples/directory that was never in the repo — so every documented command failed for anyone following along.Rather than add a duplicate set of manifests, point the commands at the existing approval-test fixtures under
approvals/, which are already the canonical sample manifests.Result
Outputs match what the README documents:
kir approvals/kir_test.TestKind.StatefulSet.input.yamlprints the three listed images.kir approvals/kir_test.TestKind.*.input.yaml | sort -uprints the listed seven.Scope
README-only — no code, test, or fixture changes. Fully standalone; no overlap with any other PR.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC