Harden CI: download deps, check fmt/vet/tidy, race tests - #52
Merged
Conversation
The test workflow ran `go mod tidy` as its dependency step, which mutates go.mod/go.sum inside CI and would hide an untidy module rather than catch it. It also ran no formatting, vet, or race checks. - Install deps with `go mod download` (non-mutating). - Fail the build on non-gofmt-ed files and on `go vet` findings. - Verify go.mod/go.sum are tidy via `go mod tidy` + `git diff --exit-code`. - Run tests with `-race`. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Strengthen the
Go Testworkflow.go mod download(non-mutating) instead ofgo mod tidy.gofmt-ed files and ongo vetfindings.go.mod/go.sumare tidy viago mod tidy+git diff --exit-code.-race.Why
The workflow ran
go mod tidyas its dependency step, which mutatesgo.mod/go.suminside CI and would hide an untidy module rather than catch it. It also ran no formatting, vet, or race checks.Notes
All new steps were validated locally against
master: fmt/vet clean, module already tidy,-racegreen. Standalone, no overlap with other PRs.🤖 Generated with Claude Code
https://claude.ai/code/session_01Pc6NAURAqjU4LYJx93tgSC
Generated by Claude Code