ci: fix tests and readthedocs#1132
Merged
Merged
Conversation
3b34358 to
d390224
Compare
This was referenced Jan 16, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
pytestas a ReadTheDocs dependency. Needed because the docs build procedure updates timestamps withdistribution/update_version.py, which usespytest. ReadTheDocs-hosted builds have been failing since #1069 because of this. The GitHub Actionsdocs.ymlworkflow has passed in the meantime because it installs the Condaenvironment.ymlbefore installing extra docs deps.Also address a few issues with external model test selection introduced in or noticed after #1130
test_z03_*.pyruns large/example model tests if the model repos are found next to the modflow6 repo. Starting with the recent release automation work, the examples repo was installed by commit-triggered CI and used by dist script tests, but commit-triggered CI now only needsmodflow6-testmodels, as was the case originally, so this PR goes back to not installing the examples. As such deselecting is not strictly necessary, but it seems best to be explicit anyway.test_z0*.pyscripts implicitly excluded models in nested directories due to the implementation of theget_example_dirs()function. Devtools finds namefiles recursively, so this PR explicitly excludes nested models intest_z03_examples.pyto keep the set of tested models unchanged.should_compare()function inautotest/conftest.py(bug caused the large model test CI failures starting after 1130)pytest.iniNote: if tests are being improperly skipped in a local dev environment after pulling recent changes,
modflow-devtoolslikely needs to be updated. If external model repositories (e.g.modflow6-testmodels,modflow6-examples) live side by side with the modflow6 repo, they will automatically be found by devtools >= 0.1.3. If the repos are somewhere else, theREPOS_PATHenv var can be set to point to the parent directory containing them. If the repos can't be found, external model tests (z0*etc) will be skipped. This is documented inDEVELOPER.mdwith more info in the devtools docs