fix: align MCP readiness checks#96
Draft
adity982 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make
/healthzaggregate readiness problems and verify that the shared state directory is writable in addition to probing the runtime dataset. Add a focused test for the non-writable-state response.Why
MCP tools rely on the same agent-owned state as the other transports. Reporting ready while that directory is read-only can admit traffic that later fails during agent actions. The readiness route remains read-only and performs no network access.
The long-term memory database is not opened here because this MCP surface does not own or use that database; the relevant shared-state requirement is the configured state directory.
Validation
ruff check agents/python/src/agent/mcp_server.py agents/python/tests/test_mcp.pygit diff --checkEnvironment note
The repository's locked test environment currently fails during collection before these tests run because
google-adk==2.4.0cannot importgoogle.adk.tools.openapi_tool.auth.credential_exchangers.auto_auth_credential_exchanger. Reinstalling the locked package reproduced the same upstream dependency error.Closes #62