Skip to content

feat: Simplify QT-based tray implementaion#121

Draft
Kishi85 wants to merge 2 commits intoLizardByte:masterfrom
Kishi85:simplify-qt-tray
Draft

feat: Simplify QT-based tray implementaion#121
Kishi85 wants to merge 2 commits intoLizardByte:masterfrom
Kishi85:simplify-qt-tray

Conversation

@Kishi85
Copy link
Copy Markdown

@Kishi85 Kishi85 commented May 8, 2026

Description

This reworks the Qt-based tray with an adapted version of QtTrayMenu.h/cpp from upstream as suggested in LizardByte/Sunshine#4907.

This currently a very early work-in-progress version of the code with all of Lizardbyte's forks additional functionality (e.g. notifications) implemented but tested only very limited.

There is also still an issue with left clicking the tray icon that is also present in the current AI based implementation which caused by https://qt-project.atlassian.net/browse/QTBUG-139921.

This version is platform-neutral for QtTrayMenu.h/cpp code with Linux platform-specifics restricted to tray_linux.cpp. Special features like XDG desktop notifications (which wouldn't have worked with Sunshine anyway due to elevated privileges) have been replaced with Qt-native equivalents. Positioning is currently also fully reliant on Qt-provided features to maintain platform independence.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@Kishi85 Kishi85 changed the title Simplify QT-based tray implementaion fix: Simplify QT-based tray implementaion May 8, 2026
@Kishi85 Kishi85 changed the title fix: Simplify QT-based tray implementaion feat: Simplify QT-based tray implementaion May 8, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 0% with 165 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (9189980) to head (ba9ba0a).

Files with missing lines Patch % Lines
src/QtTrayMenu.cpp 0.00% 148 Missing ⚠️
src/tray_linux.cpp 0.00% 17 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (9189980) and HEAD (ba9ba0a). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9189980) HEAD (ba9ba0a)
Windows 1 0
macOS 1 0
Linux-qt5 1 0
Linux-qt6 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #121       +/-   ##
==========================================
- Coverage   63.75%   0.00%   -63.76%     
==========================================
  Files           4       3        -1     
  Lines         858     214      -644     
  Branches      313      83      -230     
==========================================
- Hits          547       0      -547     
- Misses        205     214        +9     
+ Partials      106       0      -106     
Flag Coverage Δ
Linux-qt5 ?
Linux-qt6 ?
Windows ?
macOS ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/tray_linux.cpp 0.00% <0.00%> (-59.47%) ⬇️
src/QtTrayMenu.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9189980...ba9ba0a. Read the comment docs.

@Kishi85 Kishi85 force-pushed the simplify-qt-tray branch 2 times, most recently from c8455fa to 9e42800 Compare May 9, 2026 07:02
@Kishi85 Kishi85 force-pushed the simplify-qt-tray branch from 9e42800 to 00857c7 Compare May 9, 2026 07:02
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant