fix: show actual bind address in Web UI log message#4897
fix: show actual bind address in Web UI log message#4897ReenigneArcher merged 1 commit intoLizardByte:masterfrom
Conversation
|
When running multiple Sunshine instances with different bind_address values, the log message always showed 'localhost' instead of the actual IP address. This made it confusing to know which URL to use for each instance's Web UI. Now shows the configured bind_address when set, or 'localhost' as a fallback when binding to all interfaces (wildcard). Fixes LizardByte#4638
ReenigneArcher
force-pushed
the
fix/webui-bind-address-log
branch
from
b08f7a2 to
14819d1
Compare
|
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4897 +/- ##
==========================================
- Coverage 17.78% 17.25% -0.53%
==========================================
Files 111 110 -1
Lines 23990 23708 -282
Branches 10612 10375 -237
==========================================
- Hits 4266 4091 -175
+ Misses 17120 15395 -1725
- Partials 2604 4222 +1618
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2 participants
Description
When running multiple Sunshine instances with different
bind_addressvalues, the log message always showedlocalhostinstead of the actual IP address. This made it confusing to know which URL to use for each instance's Web UI.This PR modifies the log message in
confighttp.cppto show the configuredbind_addresswhen set, and falls back tolocalhostwhen binding to all interfaces (wildcard address).Screenshot
Before:
After:
With
bind_address = 10.124.62.47:Without
bind_address(default):Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage