Skip to content

Add manual rotation config option for portrait panels where KMS reports native resolution. #4877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sam1am wants to merge 4 commits into
base: master
Choose a base branch
from

fix(tests): address SonarCloud warnings in test_config.cpp

eff0d35
Select commit
Loading
Failed to load commit list.
Open

Add manual rotation config option for portrait panels where KMS reports native resolution. #4877

fix(tests): address SonarCloud warnings in test_config.cpp
eff0d35
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Apr 30, 2026 in 9m 15s

Quality Gate failed

Failed conditions
4 New issues
4 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 17 in tests/unit/test_config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ0JeozyNJS_9PPJdMc0&open=AZ0JeozyNJS_9PPJdMc0&pullRequest=4877

Check warning on line 71 in tests/unit/test_config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ0JeozyNJS_9PPJdMc3&open=AZ0JeozyNJS_9PPJdMc3&pullRequest=4877

Check warning on line 29 in tests/unit/test_config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ3cMWCdJh43CeE7j3Ap&open=AZ3cMWCdJh43CeE7j3Ap&pullRequest=4877

Check warning on line 32 in tests/unit/test_config.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=LizardByte_Sunshine&issues=AZ0JeozyNJS_9PPJdMc2&open=AZ0JeozyNJS_9PPJdMc2&pullRequest=4877
View more details on SonarQubeCloud