LF-5276: Save and return which crops or animals each expense is linked to models endpoints tests#4169
Open
SayakaOno wants to merge 17 commits into
Conversation
…relations and cropVarietiesBelongToFarm Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… allocations Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use .length check so PATCH can send farm_expense_animal: [] with farm_expense_crop_variety items to transition between allocation types. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the 404 workaround in the saga now that the API consistently returns 200 with an empty array for farms with no expenses. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…less than value (expense total)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
farmExpenseAnimalModelandfarmExpenseCropVarietyModelfarmExpenserelationscheckFarmExpensemiddleware for validationcropVarietiesBelongToFarmcheckSalefarmExpenseControllerto handle allocation modifications[]instead of404when there are no expensesPATCH sample requests:
farm_expense_crop_varietyJira link: https://lite-farm.atlassian.net/browse/LF-5276
Type of change
How Has This Been Tested?
Checklist:
pnpm i18nto help with this)