2072 clang tidy

[tomeichlersmith]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

I think with some additional testing I was able to resolve a part of #2072 and get the scheduled jobs on trunk to fail if changes would be made to source files by format/tidy/lint.

The requirement that changes be made to source files is one that I'm not happy with. I'm hoping we can enable more clang-tidy checks and some of them do not have a "auto-fix" option that change the file, but - for now at least - this will at least alert us when there are "auto-fixes" available for files on trunk.

I made a small change to a header file to trigger the apply clang tools on a changed file to see how it performs in CI. It should update the destructor to use the correct style for the local variable name lower_case instead of camelBack.

[tvami]

I like doing these as uppercase, it's a "semi sentence" to me... like bullet points in a talk, that's also uppercase but no full stop in the end. But ok that's just style

[github-actions]

Validation Results

All validation samples passed! ✅

Sample	Status
cascade_history	✅ PASS
deep_ecal_gun	✅ PASS
eat_signal	✅ PASS
ecal_pn	✅ PASS
hcal	✅ PASS
inclusive	✅ PASS
it_pileup	✅ PASS
kaon_enhanced	✅ PASS
reduced_ldmx	✅ PASS
signal	✅ PASS
signal_target_al	✅ PASS
target_genie	✅ PASS
target_pn_lyso	✅ PASS
target_ti_en	✅ PASS
wab_lhe	✅ PASS

cascade_history:

• Text Differences Between Logs (2 lines differ)
• Timing for cascade_history: gold=5968s, new=6045s
• Timing within 1% of gold (tolerance 10%)

deep_ecal_gun:

• Text Differences Between Logs (24 lines differ)
• Timing for deep_ecal_gun: gold=4091s, new=4079s
• Timing within 0% of gold (tolerance 10%)

eat_signal:

• Timing for eat_signal: gold=1602s, new=1575s
• Timing within 1% of gold (tolerance 10%)

ecal_pn:

• Text Differences Between Logs (40 lines differ)
• Timing for ecal_pn: gold=6232s, new=6532s
• Timing within 4% of gold (tolerance 10%)

hcal:

• Text Differences Between Logs (2 lines differ)
• Timing for hcal: gold=829s, new=828s
• Timing within 0% of gold (tolerance 10%)

inclusive:

• Text Differences Between Logs (34 lines differ)
• Timing for inclusive: gold=6805s, new=6588s
• Timing within 3% of gold (tolerance 10%)

it_pileup:

• Text Differences Between Logs (48 lines differ)
• Timing for it_pileup: gold=577s, new=563s
• Timing within 2% of gold (tolerance 10%)

kaon_enhanced:

• Text Differences Between Logs (36 lines differ)
• Timing for kaon_enhanced: gold=3122s, new=3047s
• Timing within 2% of gold (tolerance 10%)

reduced_ldmx:

• Text Differences Between Logs (18 lines differ)
• Timing for reduced_ldmx: gold=211s, new=210s
• Timing within 0% of gold (tolerance 10%)

signal:

• Text Differences Between Logs (32 lines differ)
• Timing for signal: gold=1184s, new=1227s
• Timing within 3% of gold (tolerance 10%)

signal_target_al:

• Text Differences Between Logs (16 lines differ)
• Timing for signal_target_al: gold=1047s, new=1046s
• Timing within 0% of gold (tolerance 10%)

target_genie:

• Text Differences Between Logs (4480 lines differ)
• Timing for target_genie: gold=6488s, new=6384s
• Timing within 1% of gold (tolerance 10%)

target_pn_lyso:

• Text Differences Between Logs (38 lines differ)
• Timing for target_pn_lyso: gold=6455s, new=6195s
• Timing within 4% of gold (tolerance 10%)

target_ti_en:

• Text Differences Between Logs (36 lines differ)
• Timing for target_ti_en: gold=3226s, new=3183s
• Timing within 1% of gold (tolerance 10%)

wab_lhe:

• Text Differences Between Logs (26 lines differ)
• Timing for wab_lhe: gold=6770s, new=6882s
• Timing within 1% of gold (tolerance 10%)