-
Notifications
You must be signed in to change notification settings - Fork 26
Eventbuilder #2029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sophiemiddleton
wants to merge
25
commits into
trunk
Choose a base branch
from
eventbuilder
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Eventbuilder #2029
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
75d682d
EB
sophiemiddleton 392debc
EB update
sophiemiddleton 7d53de7
EB update
sophiemiddleton 37311e8
moved dirs
sophiemiddleton 101406c
removed duplicates
sophiemiddleton 670920d
tidy EventBuilder CMakeLists.txt out of habit
tomeichlersmith dbceeff
need to include EventBuilder subdirectory in central CMakeLists.txt
tomeichlersmith a5fcc8d
two example configs (SingleSubsystemUnpacker and EventBuilder)
tomeichlersmith d361d0e
working builder
sophiemiddleton 10b41ae
working builder
sophiemiddleton 4092d0d
working builder
sophiemiddleton 4d428f3
working builder
sophiemiddleton d800390
working builder
sophiemiddleton 4a35a30
finalized summary product, added DAQ diagnostics
sophiemiddleton 28badfd
finalized summary product, added DAQ diagnostics
sophiemiddleton 0ad54f3
updated
sophiemiddleton 3c243c8
updated
sophiemiddleton 9318f10
removed depracated class
sophiemiddleton f183f12
edits for contributor id
sophiemiddleton f80da6f
copied Packing over
sophiemiddleton e885362
Update EventBuilder/include/EventBuilder/FragmentBuffer.hh
sophiemiddleton 73c4daa
Update EventBuilder/include/EventBuilder/FragmentBuffer.hh
sophiemiddleton f61d59a
Tamas suggestions
sophiemiddleton d8958aa
Tamas suggestions
sophiemiddleton c590709
Tamas suggestions
sophiemiddleton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,8 @@ __pycache__/ | |
| .pydevproject | ||
| *~ | ||
| *# | ||
| *.dat | ||
| *.bin | ||
| *.pyc | ||
| /bin | ||
| /lib | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| cmake_minimum_required(VERSION 3.12) | ||
| # Set the project name | ||
| project(EventBuilder | ||
| DESCRIPTION "for building complete events from the raw data." | ||
| LANGUAGES CXX | ||
| ) | ||
|
|
||
| # Set up the main EventBuilder library | ||
| setup_library( | ||
| module EventBuilder | ||
| dependencies Framework::Framework | ||
| Packing::Packing | ||
| ) | ||
|
|
||
| # Configure RPATH for the library | ||
| # Set empty RPATH to ensure the library has no embedded runtime path dependencies | ||
| set_target_properties(EventBuilder PROPERTIES | ||
| BUILD_RPATH "" | ||
| INSTALL_RPATH "" | ||
| INSTALL_RPATH_USE_LINK_PATH OFF | ||
| ) | ||
|
|
||
| setup_python(package_name LDMX/EventBuilder) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| # EventBuilder | ||
|
|
||
| EventBuilder reads raw detector data from `.dat` files and assembles complete physics events by grouping detector subsystem fragments based on timestamp coherence. | ||
|
|
||
| ## Overview | ||
|
|
||
| The EventBuilder operates as a Framework producer that: | ||
| 1. **Reads binary frames** from a `.dat` file using the Reader class for incremental streaming | ||
| 2. **Parses frame headers** (RogueFrameHeader for StreamWriter framing) | ||
| 3. **Extracts fragment data** in either RoR (LDMXRoRHeader) or packing subsystem format | ||
| 4. **Buffers fragments** by timestamp in a FragmentBuffer | ||
| 5. **Assembles events** when fragments from ≥3 different subsystems arrive within a 5ms coherence window | ||
| 6. **Outputs events** to: | ||
| - ROOT file with event-by-event subsystem data (Framework output) | ||
| - Binary file (`events.bin`) for offline analysis | ||
| - CSV summary (`event_summaries.txt`) for quick validation | ||
|
|
||
| ## Architecture | ||
|
|
||
| ### Core Classes | ||
|
|
||
| **EventBuilder** (`EventBuilder.hh`) | ||
| - Main Producer class that drives event assembly | ||
| - `configure()`: Opens the .dat file with Reader | ||
| - `produce()`: Main event loop - reads frames, parses fragments, buffers them, and assembles events | ||
|
|
||
| **FragmentBuffer** (`FragmentBuffer.hh`) | ||
| - Maintains a map of fragments organized by timestamp | ||
| - `add_fragment()`: Stores incoming fragments, sets reference time on first fragment | ||
| - `try_build_event()`: Collects all fragments within `[ref_time ± coherence_window]`, requires ≥3 unique subsystems | ||
| - Returns false if completeness check fails (incomplete event) | ||
|
|
||
| **DataFragment** (`Fragment.hh`) | ||
| - Header: subsystem_id, timestamp, contributor | ||
| - Trailer: CRC checksum | ||
| - Payload: Raw byte data from device | ||
|
|
||
| **PhysicsEventData** (`Event/PhysicsEventData.hh`) | ||
| - Event-level data structure for binary output | ||
| - Contains: event_id, timestamp, blocks (one per subsystem), systems_readout list | ||
|
|
||
| **GenericDataBlock** (`Event/GenericDataBlock.hh`) | ||
| - Per-subsystem data in an event | ||
| - Contains: subsystem_id, timestamp_ns, data (uint8_t vector), checksum | ||
|
|
||
| **EventSummary** (`EventSummary.hh`) | ||
| - CSV row for quick event validation | ||
| - Contains: event_id, timestamp_ns, # subsystems, subsystem_ids, total_payload_size, error_flags | ||
|
|
||
| ### Data Flow | ||
|
|
||
| ``` | ||
| .dat file (binary frames) | ||
| ↓ | ||
| RogueFrameHeader (frame demux, skip non-data channels) | ||
| ↓ | ||
| LDMXRoRHeader or SubsystemPacket (format detection & parsing) | ||
| ↓ | ||
| DataFragment (structured fragment) | ||
| ↓ | ||
| FragmentBuffer (timestamp-based buffering) | ||
| ↓ | ||
| try_build_event (coherence window assembly, subsystem completeness check) | ||
| ↓ | ||
| PhysicsEventData (event payload) → Binary file + CSV summary | ||
| ↓ | ||
| Framework::Event → Root file (subsystem branches) | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| ### Python Configuration | ||
|
|
||
| ```python | ||
| from LDMX.Framework import ldmxcfg | ||
| from LDMX.EventBuilder import eventbuilder | ||
| import sys | ||
|
|
||
| p = ldmxcfg.Process('unpack') | ||
| p.run = 1 | ||
| p.max_events = 100 | ||
| p.verbose_parse = True | ||
|
|
||
| p.sequence = [ | ||
| eventbuilder.from_dat_file(sys.argv[1]) # Input .dat file | ||
| ] | ||
|
|
||
| p.output_files = [sys.argv[2]] # Output .root file | ||
| p.pause() | ||
| ``` | ||
|
|
||
| Run with: | ||
| ```bash | ||
| python run_eventbuilder.py input.dat output.root | ||
| ``` | ||
|
|
||
| ### Configuration Parameters | ||
|
|
||
| - **dat_file**: Path to input binary file (or set EVENTBUILDER_INPUT env var) | ||
| - **output_name**: Name of object on event bus (default: "PhysicsEventData") | ||
| - **verbose_parse**: Enable debug logging (default: false) | ||
|
|
||
| ### Output Files | ||
|
|
||
| 1. **output.root** (Framework output) | ||
| - One TTree with event entries | ||
| - Branches: TDAQ_Trigger, TS_DAQ, TS_Trigger, Tracker_DAQ, ECAL_DAQ, ECAL_Trigger, HCAL_DAQ, HCAL_Trigger | ||
| - Each branch contains `std::vector<uint8_t>` for that subsystem's raw data | ||
| - All subsystems present in an event are grouped in the same tree entry | ||
|
|
||
| 2. **events.bin** (Binary format) | ||
| - Compact binary stream of assembled events | ||
| - Format: `[event_id: u64][timestamp: u64][nblocks: u32][blocks...]` | ||
| - Each block: `[subsys_id: u64][ts: u64][size: u32][checksum: u32][data: bytes]` | ||
|
|
||
| 3. **event_summaries.txt** (CSV) | ||
| - One line per event | ||
| - Fields: event_id, timestamp_ns, nsystems, system_ids (semicolon-separated), payload_size, error_flags | ||
| - Quick validation without parsing binary | ||
|
|
||
| ## Subsystem ID Mapping | ||
|
|
||
| Events can contain data from these subsystems (IDs 1-9): | ||
|
|
||
| | ID | Name | Description | | ||
| |---|---|---| | ||
| | 1 | TDAQ_Trigger | TDAQ trigger data | | ||
| | 2 | TS_DAQ | Target spectrometer DAQ | | ||
| | 3 | TS_Trigger | Target spectrometer trigger | | ||
| | 4 | Tracker_DAQ | Tracker detector | | ||
| | 5 | ECAL_DAQ | Electromagnetic calorimeter | | ||
| | 6 | ECAL_Trigger | ECAL trigger | | ||
| | 7 | HCAL_DAQ | Hadronic calorimeter | | ||
| | 8 | HCAL_Trigger | HCAL trigger | | ||
| | 9 | Generic | Other/unknown subsystem | | ||
|
|
||
| ## Validation | ||
|
|
||
| ### Method 1: Check CSV Summary | ||
|
|
||
| ```bash | ||
| head event_summaries.txt | ||
| ``` | ||
|
|
||
| Example output: | ||
| ``` | ||
| 1,51489468331918879,4,1;2;4;5,47140,0 | ||
| 2,51489468448398879,4,1;2;4;5,47120,0 | ||
| ``` | ||
|
|
||
| Event 1: 4 subsystems (IDs 1,2,4,5), timestamp 51489468331918879 ns, 47140 bytes total | ||
|
|
||
| ### Method 2: Read Binary File | ||
|
|
||
| ```bash | ||
| python EventBuilder/scripts/read_events.py events.bin | ||
| ``` | ||
|
|
||
| Example output: | ||
| ``` | ||
| ================================================================================ | ||
| Event 1: | ||
| Event ID: 1 | ||
| Timestamp: 51489468331918879 ns | ||
| Number of blocks: 4 | ||
| Blocks: | ||
| [0] Subsystem ID: 1 | ||
| Timestamp: 51489468331918879 ns | ||
| Payload size: 32 bytes | ||
| Data (hex): 06990d66edb60000... | ||
| [1] Subsystem ID: 2 | ||
| Timestamp: 51489468331918879 ns | ||
| Payload size: 6736 bytes | ||
| ... | ||
| ``` | ||
|
|
||
| ### Method 3: Inspect ROOT File | ||
|
|
||
| ```bash | ||
| root output.root | ||
| root [0] Events->Draw("Entries$(ECAL_DAQ)") | ||
| root [1] Events->Print() | ||
| ``` | ||
|
|
||
| Check: | ||
| - Number of entries matches `event_summaries.txt` | ||
| - Branches present match expected subsystems | ||
| - Data sizes are non-zero | ||
|
|
||
| ## Coherence Window & Event Assembly | ||
|
|
||
| **Coherence Window**: 5 milliseconds (5,000,000 nanoseconds) | ||
|
|
||
| When a fragment arrives: | ||
| 1. If buffer is empty, set reference time = fragment timestamp | ||
| 2. If fragment is within ±5ms of reference time, add to current event batch | ||
| 3. If fragment is **outside** the window, finalize current event and start new batch with this fragment | ||
|
|
||
| **Completeness Check**: Event is complete when it contains ≥3 unique subsystems | ||
|
|
||
| This ensures: | ||
| - Fragments from the same physics event (arriving within detector timing) group together | ||
| - Fragments from different beam spills (separated by >5ms) don't merge | ||
| - Partial events (missing subsystems) are rejected until they timeout or new fragment outside window triggers assembly | ||
|
|
||
|
|
||
| ## Development Notes | ||
|
|
||
| - **Reader class**: From Packing library, enables incremental binary streaming without loading entire file | ||
| - **RogueFrameHeader**: StreamWriter framing from Rogue DAQ system | ||
| - **LDMXRoRHeader**: Custom header format used by LDMX RoR protocol | ||
| - **SubsystemPacket**: Alternative packet format from Packing/RawDataFile | ||
| - **Reference time tracking**: FragmentBuffer maintains window center for robust multi-subsystem grouping | ||
| - **No ROOT dictionaries**: Event data is stored as native `std::vector<uint8_t>` which ROOT serializes natively |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| from LDMX.Framework import ldmxcfg | ||
| p = ldmxcfg.Process('builder') | ||
| p.run = 1 | ||
| p.max_events = 10000 | ||
| p.verbose_parse=True | ||
| from LDMX.EventBuilder import eventbuilder | ||
| import sys | ||
| p.sequence = [ | ||
| eventbuilder.from_dat_file(sys.argv[1]) | ||
| ] | ||
|
|
||
| # Reduce terminal logging level to see info messages | ||
| p.logger = { | ||
| "term_level": 1 # 0=debug, 1=info, 2=warn, 3=error, 4=fatal | ||
| } | ||
| p.output_files = [sys.argv[2]] | ||
| p.pause() | ||
22 changes: 22 additions & 0 deletions
22
EventBuilder/include/EventBuilder/Event/GenericDataBlock.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #ifndef GENERICDATABLOCK_H | ||
| #define GENERICDATABLOCK_H | ||
|
|
||
| #include <cstdint> | ||
| #include <vector> | ||
| #include <cstddef> | ||
| #include "EventBuilder/Fragment.h" | ||
|
|
||
| namespace eventbuilder { | ||
|
|
||
| struct GenericDataBlock { | ||
| uint64_t subsystem_id = 0; | ||
| uint64_t timestamp_ns = 0; | ||
| std::vector<uint8_t> data; // raw encoded payload | ||
| uint32_t checksum = 0; | ||
|
|
||
| size_t size() const { return data.size(); } | ||
| }; | ||
|
|
||
| } // namespace eventbuilder | ||
|
|
||
| #endif // GENERICDATABLOCK_H |
30 changes: 30 additions & 0 deletions
30
EventBuilder/include/EventBuilder/Event/PhysicsEventData.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| #ifndef PHYSICSEVENTDATA_H | ||
| #define PHYSICSEVENTDATA_H | ||
|
|
||
| #include "GenericDataBlock.h" | ||
|
|
||
| namespace eventbuilder { | ||
|
|
||
| // Combined payload that keeps subsystem data encoded as generic blocks. | ||
| struct PhysicsEventData { | ||
| long long timestamp = 0; | ||
| long long event_id = 0; | ||
|
|
||
| // Generic, encoded blocks for downstream DAQ to decode per-subsystem | ||
| std::vector<GenericDataBlock> blocks; | ||
|
|
||
| // List of subsystem ids present in the assembled event | ||
| std::vector<uint64_t> systems_readout; | ||
|
|
||
| // member to reset the stored payload. | ||
| void clear() { | ||
| timestamp = 0; | ||
| event_id = 0; | ||
| blocks.clear(); | ||
| systems_readout.clear(); | ||
| } | ||
| }; | ||
|
|
||
| } // namespace eventbuilder | ||
|
|
||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| #ifndef EVENTBUILDER_EVENTBUILDER_H | ||
| #define EVENTBUILDER_EVENTBUILDER_H | ||
| #include <string> | ||
| #include <chrono> | ||
| #include "FragmentBuffer.h" | ||
| #include "Event/PhysicsEventData.h" | ||
| #include "Framework/EventProcessor.h" | ||
| #include "Framework/Logger.h" | ||
| #include "Packing/Utility/Reader.h" | ||
|
|
||
| namespace eventbuilder { | ||
|
|
||
| class EventBuilder : public framework::Producer { | ||
| public: | ||
|
|
||
| EventBuilder(const std::string &name, framework::Process &proc) | ||
| : framework::Producer(name, proc), m_verbose_parse(false), m_event_id(0) {} | ||
|
|
||
| enableLogging("EventBuilder") | ||
|
|
||
| virtual ~EventBuilder() = default; | ||
|
|
||
| void configure(framework::config::Parameters &ps) override; | ||
|
|
||
| void produce(framework::Event &event) override; | ||
|
|
||
| private: | ||
|
|
||
| PhysicsEventData assemble_payload(const std::vector<DataFragment> &fragments); | ||
| void write_event_binary(const PhysicsEventData &ev, const std::string &path = "events.bin"); | ||
|
|
||
| bool m_verbose_parse; | ||
| unsigned int m_event_id; | ||
| FragmentBuffer m_event_buffer; | ||
| std::string m_input_file; | ||
| packing::utility::Reader m_reader; | ||
| std::string m_output_name{"BuilderOutput"}; | ||
| long long m_coherence_window_ns{5000000}; // 5 ms window for collecting fragments | ||
|
|
||
| // Performance metrics | ||
| std::chrono::steady_clock::time_point m_start_time; | ||
| std::chrono::steady_clock::time_point m_event_start_time; | ||
| uint64_t m_total_bytes_read{0}; | ||
| uint64_t m_total_events_built{0}; | ||
| unsigned long m_events_since_last_report{0}; | ||
|
|
||
| // Windowed metrics for real-time monitoring (DAQ use) | ||
| static constexpr unsigned int WINDOW_SIZE = 100; // Calculate rates over last 100 events | ||
| std::chrono::steady_clock::time_point m_window_start_time; | ||
| uint64_t m_window_events_count{0}; | ||
| uint64_t m_window_bytes_read{0}; | ||
| }; | ||
|
|
||
| } // namespace eventbuilder | ||
| #endif |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How big is the input you used to test it? Wonder if we can upload it to the ci-data repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be, it was too large to push, i know that but we could use it for validation still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the repo I had in mind: https://github.com/LDMX-Software/ci-data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can put something there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the best way to add the .dat here. I'm guessing manual upload?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but what's the size? If it's too big we could consider skimming to less events