Conversation
ecmel
marked this pull request as draft
July 10, 2026 14:26
…ITLAB_TOKEN is absent, so CI (docker/login-action) works Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ompt for GITLAB_TOKEN only if the pull fails
ecmel
marked this pull request as draft
July 14, 2026 13:57
ecmel
marked this pull request as ready for review
July 16, 2026 07:50
bjeffery-kx
approved these changes
Jul 22, 2026
bjeffery-kx
reviewed
Jul 22, 2026
bjeffery-kx
requested changes
Jul 22, 2026
Co-authored-by: bjeffery-kx <bjeffery@kx.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes introduced by this PR
npm run q-testnow runs in Docker — switched the script from invoking a localq qcumber.q(which required q on PATH) to running the test suite inside the privateqpbuildimage viaqcumber.sh. No local q install needed.qcumber.shpasses the kdb+ license to the container asKDB_K4LICENSE_B64(how CI supplies it, from a secret). If that env var is unset, it base64-encodes ak4.licfound in$QLIC,$QHOME, or~/.kx— so no manual setup when those are already configured.qpbuildimage lives in a private GitLab registry. If it isn't already local, the script pulls it. It logs in first when it can — fromGITLAB_TOKEN(a GitLab PAT withread_registryscope) or an interactive prompt — otherwise it relies on an existingdocker login.docker/login-actionstep before runningqcumber.sh, so noGITLAB_TOKENis needed there; the license is supplied as theKDB_K4LICENSE_B64secret. If a pull fails with no credentials, the script errors with a clear message.