EPMDEDP-16623: fix: Resolve pagination failure in Tekton Results query#202
Merged
Conversation
…lineRun query The getPipelineRunResults endpoint uses `order_by: summary.end_time desc` for sorting. However, RecordSummary.EndTime is NULL for many results due to a watcher bug in tektoncd/results (tektoncd/results#1285). Ordering by a NULL field corrupts the pagination cursor, causing page 2+ to return empty results. Changed to `order_by: create_time desc` which is: - Always populated (never NULL) - Semantically equivalent for recency-based sorting - The client hook already re-sorts by creationTimestamp anyway This unblocks the "Load more history" pagination control and allows users to view all 100+ PipelineRuns in the history, not just the initial 50. See: tektoncd/results#1285 Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
SergK
force-pushed
the
fix-pipelinerunlist
branch
from
028a942 to
b7580ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The getPipelineRunResults endpoint uses
order_by: summary.end_time descfor sorting. However, RecordSummary.EndTime is NULL for many results due to a watcher bug in tektoncd/results (tektoncd/results#1285). Ordering by a NULL field corrupts the pagination cursor, causing page 2+ to return empty results.Changed to
order_by: create_time descwhich is:This unblocks the "Load more history" pagination control and allows users to view all 100+ PipelineRuns in the history, not just the initial 50.
See: tektoncd/results#1285