Combine tests to check output visually#3
Open
radarhere wants to merge 1 commit intoKrishnachaitanyakc:add-dashed-line-supportfrom
Open
Combine tests to check output visually#3radarhere wants to merge 1 commit intoKrishnachaitanyakc:add-dashed-line-supportfrom
radarhere wants to merge 1 commit intoKrishnachaitanyakc:add-dashed-line-supportfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion for python-pillow#9490
I've combined the different shape tests, checking the visual output for more operations.
However, when I changed the polygon points to be something other than a rectangle, I found that the dashed line does exactly sit on the edge of the polygon.
I can think of a solution to this when the width is 1 pixel, but more than that could be complicated. Would you be happy with only supporting widths of 1 pixel?