Skip to content

chore: pnpm migration[KHCP-21042] #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharmaadityaHQ wants to merge 6 commits into
base: main
Choose a base branch
from
+463 −433
Open

chore: pnpm migration[KHCP-21042] #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
11e06cc
chore: pnpm migration
sharmaadityaHQ Jul 3, 2026
c1e26f6
chore: update lockfile
sharmaadityaHQ Jul 3, 2026
03c814b
chore: update lock file via pnpm v11
sharmaadityaHQ Jul 3, 2026
08eee33
chore: audit fixes
sharmaadityaHQ Jul 3, 2026
3c3908d
fix: comment in CI
sharmaadityaHQ Jul 6, 2026
b181bda
chore: remove auto install peer dependencies flag
sharmaadityaHQ Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/CI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@ jobs:
tag="pr-${{ github.event.pull_request.number }}"
echo "preid=${preid}"

# Use yarn to bump the version for the prerelease
pnpm version prerelease --preid ${preid} --no-git-tag-version --yes --amend
# Use pnpm to bump the version for the prerelease
pnpm version prerelease --preid ${preid} --no-git-tag-version --yes

@ValeryG ValeryG Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is --amend removed?

@sharmaadityaHQ sharmaadityaHQ Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amend flag was droppend in pnpm v11. was leading to ERROR: Unknown option: 'amend'. no-git-tag-version already helps ensure no git commit or tag is created here.

@sharmaadityaHQ sharmaadityaHQ Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like amend wasn't there in previous versions either. v11 has a native publish flow as mentioned in the highlights section point 6 here - https://pnpm.io/blog/releases/11.0. earlier it used to delegate to the npm CLI where passing extra flags was not erroring.

@sharmaadityaHQ sharmaadityaHQ Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference to the above comment - https://pnpm.io/pnpm-cli#differences-vs-npm. "Unlike npm, pnpm validates all options"


package_version=$(jq -r ".version" package.json)
package=@kong/spec-renderer@"${package_version}"
Expand All @@ -88,14 +88,15 @@ jobs:

npm_instructions=""

pkg=$(pnpm publish --no-git-checks --access public --report-summary --tag "${tag}" | grep "+ "| sed 's/+ //')
pnpm publish --no-git-checks --access public --tag "${tag}"

if [[ -z "${pkg}" ]]; then
if [ $? -ne 0 ]; then
Comment on lines -91 to +93

@adamdehaven adamdehaven Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this refactor necessary?

@sharmaadityaHQ sharmaadityaHQ Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, pnpm v11 changed the publish output format. the CI would fail with Error publishing package without this change.

@adamdehaven adamdehaven Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave some more context on the pull request; otherwise, we're just assuming what the changes are.

Please leave some context in the areas that were changed

echo "Error publishing package"
exit -1
Comment on lines +91 to 95
fi

npm_instructions="@$(echo ${pkg}|cut -d'@' -f2)@${tag}"
package_name=$(jq -r ".name" package.json)
npm_instructions="${package_name}@${tag}"
Comment on lines -98 to +99

@adamdehaven adamdehaven Jul 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this refactor necessary?

@sharmaadityaHQ sharmaadityaHQ Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, pkg is removed in the above pnpm publish step and its simpler to read package name from package.json just like we read version on line 80.


echo "npm_instructions<<EOF" >> $GITHUB_OUTPUT
echo -e "$npm_instructions" >> $GITHUB_OUTPUT
Expand Down
2 changes: 0 additions & 2 deletions .npmrc
View file
Open in desktop

This file was deleted.

58 changes: 2 additions & 56 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,65 +125,11 @@
"vite-plugin-node-polyfills": "^0.26.0",
"vite-plugin-replace": "^0.1.1",
"vite-plugin-vue-devtools": "^8.1.2",
"vitest": "3.2.4",
"vitest": "3.2.6",
"vue": "^3.5.34",
"vue-router": "^4.6.4",
"vue-tsc": "^3.2.9"
},
"pnpm": {
"onlyBuiltDependencies": [
"@evilmartians/lefthook",
"@parcel/watcher",
"esbuild",
"vue-demi"
],
"overrides": {
"openapi3-ts": "4.6.0",
"jsonpath-plus@<10.3.0": ">=10.4.0",
"elliptic@<=6.6.0": ">=6.6.1",
"@babel/helpers@<7.26.10": ">=7.29.2",
"cross-spawn@>=7.0.0 <7.0.5": ">=7.0.6",
"brace-expansion@>=1.0.0 <=1.1.11": ">=2.1.0",
"brace-expansion@>=2.0.0 <=2.0.1": ">=2.0.2",
"pbkdf2@<=3.1.2": ">=3.1.5",
"sha.js@<=2.4.11": ">=2.4.12",
"cipher-base@<=1.0.4": ">=1.0.7",
"glob@>=10.2.0 <10.5.0": ">=13.0.6",
"diff@>=4.0.0 <4.0.4": ">=4.0.4",
"@isaacs/brace-expansion@<=5.0.0": ">=5.0.1",
"mdast-util-to-hast@>=13.0.0 <13.2.1": ">=13.2.1",
"qs@>=6.7.0 <=6.15.1": ">=6.15.2",
"bn.js@>=5.0.0 <5.2.3": ">=5.2.3",
"bn.js@<4.12.3": ">=5.2.3",
"rollup@>=4.0.0 <4.59.0": ">=4.62.2",
"minimatch@<10.2.3": ">=10.2.5",
"ajv@<6.14.0": "^6.15.0",
"immutable@>=5.0.0 <5.1.5": ">=5.1.5",
"flatted@<=3.4.1": ">=3.4.2",
"undici@<6.24.0": ">=8.5.0",
"handlebars@>=4.0.0 <4.7.9": ">=4.7.9",
"picomatch@<2.3.2": ">=4.0.4",
"lodash-es@<=4.17.23": ">=4.18.0",
"lodash@<=4.17.23": ">=4.18.0",
"yaml@>=2.0.0 <2.8.3": ">=2.9.0",
"fast-uri@<=3.1.1": ">=3.1.2",
"uuid@<11.1.1": ">=11.1.1",
"vitest@<3.2.6": ">=3.2.6",
"brace-expansion@>=5.0.0 <5.0.6": ">=5.0.6",
"js-cookie@<=3.0.5": ">=3.0.7",
"tmp@<0.2.6": ">=0.2.6",
"esbuild@>=0.27.3 <0.28.1": ">=0.28.1",
"sanitize-html@=2.17.3": ">=2.17.4",
"ws@>=8.0.0 <8.21.0": ">=8.21.0",
"form-data@>=4.0.0 <4.0.6": ">=4.0.6",
"vite@>=7.0.0 <=7.3.4": ">=7.3.5",
"@babel/core@<=7.29.0": ">=7.29.6",
"markdown-it@<=14.1.1": ">=14.2.0",
"linkify-it@<=5.0.0": ">=5.0.1",
"js-yaml@>=4.0.0 <=4.1.1": ">=4.2.0",
"undici@>=7.0.0 <7.28.0": ">=7.28.0"
}
},
"repository": {
"type": "git",
"url": "git+https://github.com/Kong/spec-renderer.git"
Expand Down Expand Up @@ -238,7 +184,7 @@
},
"volta": {
"node": "24.18.0",
"pnpm": "10.33.4"
"pnpm": "11.5.3"
},
"config": {
"commitizen": {
Expand Down
Loading
Loading