Closed
fix: explicit type annotations for throttle callbacks broken by @octokit/plugin-retry v8.1.0#1719
Conversation
1 task
…rors with @octokit/plugin-retry v8.1.0 Co-authored-by: Kesin11 <1324862+Kesin11@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update dependency @octokit/plugin-retry to v8.1.0
fix: explicit type annotations for throttle callbacks broken by @octokit/plugin-retry v8.1.0
Mar 6, 2026
Owner
|
Thanks to implement workaround copilot. However, it might fix octokit/plugin-retry.js#666 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@octokit/plugin-retryv8.1.0 changed its module augmentation target from@octokit/coreto@octokit/core/types(a distinct TypeScript module path), breaking contextual type inference for thethrottle.onRateLimitandthrottle.onSecondaryRateLimitcallback parameters inGithubClient.Changes
src/client/github_client.ts: Add explicit type annotations to throttle callback parameters; extract a sharedThrottleRequestOptionstype alias to avoid duplication.{ method: string; url: string }is a structural supertype ofRequired<EndpointDefaults>, so it satisfies the contra-variant parameter check understrictFunctionTypes.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.