Shed chapters that a re-parse no longer maps to

[StereotypicalCat]

Fixed

• Fixed: Fixed a bug where chapters that no longer parse out of a filename stayed in the library forever, even after a forced scan. For example, 'Blade Runner 2019 - Volume 1.pdf' was previously read as both Volume 1 and Chapter 2019, and kept showing a Chapter 2019 entry long after parsing stopped producing one. (Fixes Kavita doesnt remove old scanner results after parser change. #4831)

[majora2007]

This seems to be 100% AI coded. The test also feels a bit shallow. This needs more looking into.

[StereotypicalCat]

Thanks for taking a look :)

On the AI point: AI was involved in reviewing* the change, but the fix is mine :) I traced the behavior in RemoveChapters using Riders debugger on a copy of my own library, and id be happy to walk through my reasoning if that would help get this PR over the line.

I agree that my test is shallow though, as my actual verification was done live, where ie edited the parser directly, forced a re-scan, and confirmed the old chapters got removed. I wasnt sure how much to invest in stubbing out a parser difference in a way that wouldn't stop working if there were changes to code structure in the future, and I didnt want to make too many changes for what I wanted to be a short and "self-contained" code fix.

Is there anything I can do to make this easier to accept? :)