Overhauled the CI setup by majora2007 · Pull Request #4486 · Kareadita/Kavita

majora2007 · 2026-03-03T17:13:45Z

Developer

Massive changes to the overall build system. Switched to ubuntu-24.04, added nuget caching, removed duplicate builds and extra jobs that added no value.
Fixed issues with develop pipeline running on release flows
Added ability to retrigger release pipeline manually in case of failure
Fixed the PR body check to actually work and run on every edit.

…, added nuget caching, removed duplicate builds and extra jobs that added no value.

…on didn't seem to work reliably

Copilot

Pull request overview

This PR refactors the GitHub Actions CI workflows to streamline builds on Ubuntu 24.04 and add dependency caching, while removing some duplicate/unused jobs.

Changes:

Moved several workflows from Windows runners to ubuntu-24.04 and reduced checkout depth where full history isn’t needed.
Added npm cache configuration (actions/setup-node built-in caching) and explicit NuGet caching (actions/cache) across multiple workflows.
Simplified workflow job graphs (removed intermediate “upload csproj” build jobs and adjusted needs accordingly) and updated the PR-body validation action version.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
.github/workflows/release-workflow.yml	Removes intermediate build job; adds npm + NuGet caching in stable build pipeline.
.github/workflows/pr-check.yml	Triggers PR-body validation on `opened` + `synchronize`; bumps action version.
.github/workflows/openapi-gen.yml	Removes PR trigger; adds NuGet caching for OpenAPI generation job.
.github/workflows/develop-workflow.yml	Removes intermediate build job; adds npm + NuGet caching; updates job dependencies.
.github/workflows/comment-on-issues.yml	Reduces checkout depth for issue-commenting automation.
.github/workflows/codeql.yml	Removes CodeQL autobuild and replaces with explicit `dotnet build`.
.github/workflows/canary-workflow.yml	Collapses build/version steps; switches to `npm ci`; adds caching; adjusts dependencies.
.github/workflows/build-ui.yml	Moves UI build to Ubuntu 24.04; reduces checkout depth; enables npm caching.
.github/workflows/build-and-test.yml	Moves build/test to Ubuntu 24.04; reduces checkout depth; adds NuGet caching.

Comments suppressed due to low confidence (1)

.github/workflows/codeql.yml:72

The manual dotnet build step runs for every entry in the CodeQL language matrix, including javascript-typescript. This adds unnecessary work and can make JS/TS analysis fail due to unrelated .NET build issues. Consider gating this step (and the .NET setup step) behind if: matrix.language == 'csharp', or split into separate jobs per language.

    - run: |
        echo "Run, Build Application using script"
        dotnet build Kavita.sln

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

… doing anything.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

majora2007 · 2026-03-03T21:06:49Z

I think we are good to merge this in. Copilot is now referencing old code.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-03-03T21:27:00Z

@majora2007 I've opened a new pull request, #4487, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: majora2007 <735851+majora2007@users.noreply.github.com>

majora2007 · 2026-03-22T12:44:20Z

I'm still nervous about the stable release. Going to hold on this for a bit till we are closer to a stable release.

Massive changes to the overall build system. Switched to ubuntu-24.04…

15aa236

…, added nuget caching, removed duplicate builds and extra jobs that added no value.

Copilot AI review requested due to automatic review settings March 3, 2026 17:13

majora2007 changed the title ~~[skip ci] Overhauled the CI setup~~ Overhauled the CI setup Mar 3, 2026

Copilot started reviewing on behalf of majora2007 March 3, 2026 17:14 View session

Replaced the PR check with a custom script since the pr-contains-acti…

80b0a71

…on didn't seem to work reliably

Copilot AI reviewed Mar 3, 2026

View reviewed changes

majora2007 added 3 commits March 3, 2026 11:22

More tweaks of custom script

f6a27d5

Switched to global tooling for swashbuckle.

08a0687

Switched canary to my personal bump GA

f0e3309

majora2007 requested a review from Copilot March 3, 2026 18:19

Copilot started reviewing on behalf of majora2007 March 3, 2026 18:20 View session

majora2007 requested a review from Fesaa March 3, 2026 18:23

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/pr-check.yml Outdated

majora2007 added 4 commits March 3, 2026 14:19

Changed the develop workflow to not run on stable releases.

a1b0ecf

Updated stable workflow to be able to re-run properly

365823b

Removed uploading of csproj as we can just get from git and it wasn't…

f8603c3

… doing anything.

Ensure everything is using the same build image

2948592

majora2007 requested a review from Copilot March 3, 2026 20:20

majora2007 added this to v0.9.0 - Reading List Overhaul Mar 3, 2026

github-project-automation Bot moved this to Todo in v0.9.0 - Reading List Overhaul Mar 3, 2026

Copilot started reviewing on behalf of majora2007 March 3, 2026 20:21 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/release-workflow.yml Outdated

Comment thread .github/workflows/pr-check.yml Outdated

Fixed a injection issue and cleaned up a dead variable

c2b9aa3

majora2007 requested a review from Copilot March 3, 2026 20:29

Copilot started reviewing on behalf of majora2007 March 3, 2026 20:30 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/release-workflow.yml Outdated

Comment thread .github/workflows/pr-check.yml Outdated

Comment thread .github/workflows/canary-workflow.yml Outdated

Comment thread .github/workflows/release-workflow.yml Outdated

More PR Comments

35abda3

majora2007 requested a review from Copilot March 3, 2026 20:40

Copilot started reviewing on behalf of majora2007 March 3, 2026 20:41 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/release-workflow.yml Outdated

Comment thread .github/workflows/release-workflow.yml

Comment thread .github/workflows/release-workflow.yml Outdated

Hopefully the last comments

592ada8

majora2007 requested a review from Copilot March 3, 2026 21:00

Copilot started reviewing on behalf of majora2007 March 3, 2026 21:00 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/release-workflow.yml

Comment thread .github/workflows/release-workflow.yml Outdated

Indentation issues

b27f200

majora2007 requested a review from Copilot March 3, 2026 21:17

Copilot started reviewing on behalf of majora2007 March 3, 2026 21:18 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

Comment thread .github/workflows/release-workflow.yml

Comment thread .github/workflows/develop-workflow.yml

Comment thread .github/workflows/build-and-test.yml

Update .github/workflows/release-workflow.yml

8ea3518

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Mar 3, 2026

ci: Add least-privilege permissions to check-source job #4487

Merged

[WIP] Address feedback on CI setup overhaul (#4487)

c6ed115

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: majora2007 <735851+majora2007@users.noreply.github.com>

majora2007 marked this pull request as draft April 24, 2026 14:13

Uh oh!

Uh oh!

Conversation

majora2007 commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Developer

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

majora2007 commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

majora2007 commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

majora2007 commented Mar 3, 2026 •

edited

Loading